Add testing of bitflips in packet headers #22267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t8m
added
branch: master
|
This needs to be rebased after #22243 is merged. |
mattcaswell
requested changes
Oct 3, 2023
Care will need to be taken when rebasing. Flipped bits will (presumably) cause the datagram to be dropped, so we will need to back off that type of noise too. |
paulidale
approved these changes
Oct 4, 2023
paulidale
removed
the
approval: otc review pending
|
This needs a rebase now that #22243 has been merged. |
A new type of noise is introduced in the noisy dgram bio filter.
t8m
force-pushed
the
quic-header-bitflips
branch
from
f272254
to
c1af473
Compare
|
Rebased and @mattcaswell comments addressed. Please reconfirm. |
mattcaswell
previously approved these changes
Oct 4, 2023
|
The no-cmp runchecker CI failure is relevant |
|
CI failure is still happening |
The test server cannot really cope with modifications
mattcaswell
reviewed
Oct 4, 2023
t8m
added
the
approval: otc review pending
mattcaswell
approved these changes
Oct 4, 2023
It passed! |
t8m
removed
the
approval: otc review pending
paulidale
approved these changes
Oct 4, 2023
paulidale
removed
the
approval: review pending
paulidale
added
the
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to the master branch. Thank you for the reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
Oct 6, 2023
A new type of noise is introduced in the noisy dgram bio filter. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #22267)
openssl-machine
pushed a commit
that referenced
this pull request
Oct 6, 2023
The test server cannot really cope with modifications Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #22267)
wanghao75
pushed a commit
to openeuler-mirror/openssl
that referenced
this pull request
Oct 9, 2023
A new type of noise is introduced in the noisy dgram bio filter. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl/openssl#22267) Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75
pushed a commit
to openeuler-mirror/openssl
that referenced
this pull request
Oct 9, 2023
The test server cannot really cope with modifications Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl/openssl#22267) Signed-off-by: fly2x <fly2x@hitls.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new type of noise is introduced in the noisy dgram bio filter.
Checklist