Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows CI: Continue on error during cpuinfo #22293

Closed
wants to merge 2 commits into from
Closed

Windows CI: Continue on error during cpuinfo #22293

wants to merge 2 commits into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Oct 5, 2023

We recently see errors during the cpuinfo commands on windows runners. This would allow some further investigation.

@t8m t8m added branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug labels Oct 5, 2023
@t8m t8m closed this Oct 5, 2023
@t8m t8m reopened this Oct 5, 2023
@paulidale paulidale added the approval: review pending This pull request needs review by a committer label Oct 5, 2023
@t8m t8m added the tests: exempted The PR is exempt from requirements for testing label Oct 6, 2023
@t8m t8m closed this Oct 6, 2023
@t8m t8m reopened this Oct 6, 2023
@t8m
Copy link
Member Author

t8m commented Oct 6, 2023

When merging, the commit marked drop! must be dropped.

@t8m t8m closed this Oct 6, 2023
@t8m t8m reopened this Oct 6, 2023
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 6, 2023
@t8m
Copy link
Member Author

t8m commented Oct 6, 2023

This is actually urgent as we have CI failures.

@t8m t8m added the severity: urgent Fixes an urgent issue (exempt from 24h grace period) label Oct 6, 2023
@t8m
Copy link
Member Author

t8m commented Oct 6, 2023

@tom-cosgrove-arm @paulidale OK with urgent?

@tom-cosgrove-arm
Copy link
Contributor

OK with urgent

mattcaswell
mattcaswell approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree urgent

@t8m
Copy link
Member Author

t8m commented Oct 6, 2023

Merging.

@t8m t8m added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 6, 2023
@t8m
Copy link
Member Author

t8m commented Oct 6, 2023

Merged to the master branch. Thank you for the reviews.

@t8m t8m closed this Oct 6, 2023
openssl-machine pushed a commit that referenced this pull request Oct 6, 2023
@t8m
Windows CI: Continue on error during cpuinfo
4ace824 
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #22293)
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Oct 9, 2023
@t8m
Windows CI: Continue on error during cpuinfo
7f08758 
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#22293)

Signed-off-by: fly2x <fly2x@hitls.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period) tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@t8m @tom-cosgrove-arm @mattcaswell @paulidale