Pss ex saltlen #2236
Closed
Pss ex saltlen #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richsalz
approved these changes
Jan 16, 2017
| RSAerr(RSA_F_PKEY_RSA_CTRL, RSA_R_PSS_SALTLEN_TOO_SMALL); | ||
| return 0; | ||
| if (rsa_pss_restricted(rctx)) { | ||
| if (p1 == -2 && ctx->operation == EVP_PKEY_OP_VERIFY) { |
There was a problem hiding this comment.
should the -2 and -1 be define's? or comented? or is this very-well-known to everyone who knows PSS?
There was a problem hiding this comment.
Yes we could do with some added defines for this and tidy up the ambiguity (-2 does different things on sign and verify).
richsalz
approved these changes
Jan 17, 2017
levitte
pushed a commit
that referenced
this pull request
Jan 18, 2017
Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #2236)
levitte
pushed a commit
that referenced
this pull request
Jan 18, 2017
Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #2236)
levitte
pushed a commit
that referenced
this pull request
Jan 18, 2017
Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #2236)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
This adds support for the special -1, -2 salt lengths for PSS only keys, apart from auto detect of salt length on verify.