Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup of general tls record parsing functions for dtls 1.3 #22376

Closed
wants to merge 2 commits into from
Closed

Fixup of general tls record parsing functions for dtls 1.3 #22376

wants to merge 2 commits into from

Conversation

fwh-dc
Copy link
Contributor

@fwh-dc fwh-dc commented Oct 13, 2023

No description provided.

@fwh-dc fwh-dc mentioned this pull request Oct 17, 2023
Closed
@t8m t8m added this to the DTLS-1.3 milestone Oct 18, 2023
@t8m t8m added the triaged: feature The issue/pr requests/adds a feature label Oct 18, 2023
@fwh-dc fwh-dc changed the base branch from master to feature/dtls-1.3 March 21, 2024 12:47
@fwh-dc fwh-dc closed this Mar 21, 2024
@fwh-dc fwh-dc reopened this Mar 21, 2024
@fwh-dc
Copy link
Contributor Author

fwh-dc commented Mar 22, 2024

Ci failures look irrelevant

@nhorman nhorman mentioned this pull request Apr 3, 2024
Open
t8m
t8m requested changes Apr 4, 2024
View reviewed changes
ssl/record/methods/tls_common.c Outdated Show resolved Hide resolved
@t8m t8m added approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member tests: deferred Tests will be added in a subsequent PR (label should be removed when the PR with tests is merged) labels Apr 4, 2024
@fwh-dc fwh-dc force-pushed the fix-some-more-tls-record-processing-functions branch from a9ae6e8 to acb0430 Compare April 8, 2024 09:43
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Apr 8, 2024
@openssl-machine openssl-machine force-pushed the feature/dtls-1.3 branch 2 times, most recently from fbea037 to 553fcfb Compare April 23, 2024 11:08
@fwh-dc fwh-dc force-pushed the fix-some-more-tls-record-processing-functions branch from acb0430 to 7bc6b3f Compare April 25, 2024 10:00
@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 25, 2024
@fwh-dc fwh-dc force-pushed the fix-some-more-tls-record-processing-functions branch from 7bc6b3f to 4773520 Compare April 25, 2024 10:49
t8m
t8m approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattcaswell please reconfirm

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: done This pull request has the required number of approvals labels Apr 25, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 26, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Apr 26, 2024

Merged to the feature branch. Thank you for your contribution.

@t8m t8m closed this Apr 26, 2024
openssl-machine pushed a commit that referenced this pull request Apr 26, 2024
@fwh-dc @t8m
tls_post_encryption_processing_default() and tls_validate_record_head…
789f7c6 
…er()

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #22376)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge tests: deferred Tests will be added in a subsequent PR (label should be removed when the PR with tests is merged) triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Milestone
DTLS-1.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fwh-dc @openssl-machine @t8m @mattcaswell