If we fail to output anything when generating a datagram we should fail #22425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If when generating a datagram we are unable to output anything then we are not making progress and we should fail, otherwise we may get into an infinite loop (i.e. continually trying to output a datagram and continually failing to do so in an infinite loop). Fixes openssl#22412
mattcaswell
added
branch: master
|
Should the size of the token be bounded in some way? I could not see anything in the RFC about this, but in the fuzz file that found this the token consumes most of the space that we have in the datagram leaving little space for anything else. |
|
It would seem reasonable to me to fail the connection if we receive retry packets with such large token (after validating the retry integrity tag of course). This is a really pathological retry packet. |
t8m
added
triaged: bug
|
Working on an alternative fix |
|
Should this get closed? |
|
Yep, the alternative was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If when generating a datagram we are unable to output anything then we are not making progress and we should fail, otherwise we may get into an infinite loop (i.e. continually trying to output a datagram and continually failing to do so in an infinite loop).
Fixes #22412