Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic_record, quicapi, and quicfaults tests do not support fuzzing builds #22472

Closed
wants to merge 1 commit into from
Closed

quic_record, quicapi, and quicfaults tests do not support fuzzing builds #22472

wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Oct 23, 2023

No description provided.

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug severity: urgent Fixes an urgent issue (exempt from 24h grace period) tests: exempted The PR is exempt from requirements for testing labels Oct 23, 2023
@t8m
Copy link
Member Author

t8m commented Oct 23, 2023

These fix a new CI failure on master branch -> urgent

mattcaswell
mattcaswell approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree urgent

@mattcaswell mattcaswell removed the approval: otc review pending This pull request needs review by an OTC member label Oct 23, 2023
hlandau
hlandau approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@hlandau hlandau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree urgent

@hlandau hlandau added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 23, 2023
@mattcaswell mattcaswell added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 23, 2023
@mattcaswell
Copy link
Member

Pushed.

openssl-machine pushed a commit that referenced this pull request Oct 23, 2023
@t8m @mattcaswell
quic_record, quicapi, and quicfaults tests do not support fuzzing builds
fac61ea 
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #22472)
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Oct 26, 2023
@t8m
quic_record, quicapi, and quicfaults tests do not support fuzzing builds
29e15e5 
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#22472)

Signed-off-by: fly2x <fly2x@hitls.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlandau hlandau hlandau approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period) tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t8m @mattcaswell @hlandau