Make s_client -quic -debug work #22480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback that makes -debug print the data sent/received needed extending for the new QUIC callback codes.
In s_client, when using quic, if we have data from the user to write then we shouldn't hang in "select" waiting for something to happen.
mattcaswell
added
branch: master
t8m
added
triaged: bug
t8m
approved these changes
Oct 24, 2023
t8m
removed
the
approval: otc review pending
hlandau
added a commit
to hlandau/openssl
that referenced
this pull request
Oct 24, 2023
hlandau
approved these changes
Oct 24, 2023
hlandau
added
approval: done
paulidale
approved these changes
Oct 25, 2023
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Pushed. |
openssl-machine
pushed a commit
that referenced
this pull request
Oct 25, 2023
The callback that makes -debug print the data sent/received needed extending for the new QUIC callback codes. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #22480)
openssl-machine
pushed a commit
that referenced
this pull request
Oct 25, 2023
In s_client, when using quic, if we have data from the user to write then we shouldn't hang in "select" waiting for something to happen. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #22480)
openssl-machine
pushed a commit
that referenced
this pull request
Oct 26, 2023
Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #22487)
wanghao75
pushed a commit
to openeuler-mirror/openssl
that referenced
this pull request
Nov 4, 2023
The callback that makes -debug print the data sent/received needed extending for the new QUIC callback codes. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl/openssl#22480) Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75
pushed a commit
to openeuler-mirror/openssl
that referenced
this pull request
Nov 4, 2023
In s_client, when using quic, if we have data from the user to write then we shouldn't hang in "select" waiting for something to happen. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl/openssl#22480) Signed-off-by: fly2x <fly2x@hitls.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback that makes -debug print the data sent/received needed extending
for the new QUIC callback codes.
We also fix a bug in s_client which made it pause unnecessarily when writing data collected from the user.
fixes openssl/project#254