quic: update ddd makefile and demo sources #22542
Conversation
doc/designs/ddd/Makefile
Outdated
| ddd-06-mem-uv-quic: ddd-06-mem-uv.c | ||
| $(CC) $(CFLAGS) $(LDFLAGS) -DUSE_QUIC -o "$@" "$<" $(LDLIBS) -luv | ||
| ddd-06-mem-uv-quic: LDLIBS = $(LDLIBS_BASE) -luv | ||
| ddd-06-mem-uv-tls: LDLIBS = $(LDLIBS_BASE) -luv |
There was a problem hiding this comment.
These two don't look right. Are they a GNUMake-ism?
There was a problem hiding this comment.
In GNU make, this is called "target specific variable values":
https://www.gnu.org/software/make/manual/make.html#Target_002dspecific
I am not certain how well it is supported by other versions of make. It may very well be a GNU make-ism.
This makefile uses pattern rules (i.e. rules that use %), so it was already broken for make versions that do not have that (like nmake).
The thing I wanted to make more clear in the makefile was that all the demos are built the same way, except that demo ddd-06 needs to link against libuv.
We could just use the same LDLIBS options for building each ddd demo, and that would simpler.
There was a problem hiding this comment.
We should avoid GNU specific stuff IMO.
Pattern rules date way way back, I'm less concerned about them. Other Makefiles in the demos area use them, so redressing this should be a separate PR IMO.
There was a problem hiding this comment.
understood.
The question remains whether or not target specific variable values is GNU make specific. I do not have enough experience with other make implementations to judge that.
I found that Ubuntu has a NetBSD make package. I installed it, but I cannot get "bmake" to build any of these demos. It does not seem to support pattern rules.
There was a problem hiding this comment.
I've just pushed an update. Let me know if you are okay with this version of the makefile.
|
Thanks for your comments, Pauli. I've fixed all the indentation issues and will mark those as resolved. |
t8m
added
branch: master
Update makefile and fix some signedness issues in the demo sources. Drop stray "\n" in the host-port format string that prevented ddd-01 from working (this was also noticed by Neil H). Also, determine the length of the message we are sending and send that many bytes (rather than send sizeof the buffer storing the message). These changes are part of openssl/project#253
t8m
removed
the
approval: otc review pending
hlandau
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to master and 3.2. Thank you. |
Update makefile and fix some signedness issues in the demo sources. Drop stray "\n" in the host-port format string that prevented ddd-01 from working (this was also noticed by Neil H). Also, determine the length of the message we are sending and send that many bytes (rather than send sizeof the buffer storing the message). These changes are part of openssl/project#253 Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #22542)
Update makefile and fix some signedness issues in the demo sources. Drop stray "\n" in the host-port format string that prevented ddd-01 from working (this was also noticed by Neil H). Also, determine the length of the message we are sending and send that many bytes (rather than send sizeof the buffer storing the message). These changes are part of openssl/project#253 Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #22542) (cherry picked from commit d1338fc)
Update makefile and fix some signedness issues in the demo sources. Drop stray "\n" in the host-port format string that prevented ddd-01 from working (this was also noticed by Neil H). Also, determine the length of the message we are sending and send that many bytes (rather than send sizeof the buffer storing the message). These changes are part of openssl/project#253 Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl/openssl#22542) Signed-off-by: fly2x <fly2x@hitls.org>
Update makefile and fix some signedness issues in the demo sources. Also, determine the length of the message we are sending and send that many bytes (rather than send sizeof the buffer storing the message).
These changes are part of openssl/project#253