Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUIC TXP: Fix use of implicit-length STREAM frames in presence of PATH_REPSONSE frames #22615

Closed
wants to merge 3 commits into from

Conversation

hlandau
Copy link
Member

@hlandau hlandau commented Nov 3, 2023

Alternative to #22611
Fixes #22607

@hlandau hlandau added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug tests: exempted The PR is exempt from requirements for testing branch: 3.2 Merge to openssl-3.2 labels Nov 3, 2023
@hlandau hlandau added this to the 3.2.0 milestone Nov 3, 2023
@hlandau hlandau self-assigned this Nov 3, 2023
@mattcaswell mattcaswell removed the approval: otc review pending This pull request needs review by an OTC member label Nov 3, 2023
ssl/quic/quic_txp.c Outdated Show resolved Hide resolved
ssl/quic/quic_txp.c Outdated Show resolved Hide resolved
@hlandau
Copy link
Member Author

hlandau commented Nov 3, 2023

Updated.

@mattcaswell
Copy link
Member

Needs a second approval on this

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Nov 7, 2023
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Nov 8, 2023
@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Nov 8, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@hlandau
Copy link
Member Author

hlandau commented Nov 8, 2023

Merged to master and 3.2. Thanks for the reviews.

@hlandau hlandau closed this Nov 8, 2023
openssl-machine pushed a commit that referenced this pull request Nov 8, 2023
…H_REPSONSE frames

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #22615)
openssl-machine pushed a commit that referenced this pull request Nov 8, 2023
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #22615)
openssl-machine pushed a commit that referenced this pull request Nov 8, 2023
…H_REPSONSE frames

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #22615)

(cherry picked from commit 3bef14c)
openssl-machine pushed a commit that referenced this pull request Nov 8, 2023
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #22615)

(cherry picked from commit e1c15a8)
@t8m t8m mentioned this pull request Nov 13, 2023
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Nov 14, 2023
…H_REPSONSE frames

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#22615)

Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Nov 14, 2023
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#22615)

Signed-off-by: fly2x <fly2x@hitls.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.2 Merge to openssl-3.2 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

quic-client fuzzer crash
4 participants