Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: add link to OpenSSL 3.2 manual pages #22625

Closed
wants to merge 1 commit into from
Closed

README: add link to OpenSSL 3.2 manual pages #22625

wants to merge 1 commit into from

Conversation

mspncp
Copy link
Contributor

@mspncp mspncp commented Nov 4, 2023

No description provided.

@levitte levitte added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: documentation The issue/pr deals with documentation (errors) tests: exempted The PR is exempt from requirements for testing branch: 3.2 Merge to openssl-3.2 labels Nov 5, 2023
@slontis slontis added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Nov 6, 2023
@openssl-machine openssl-machine deleted the mspncp-patch-1 branch November 6, 2023 07:49
@mspncp mspncp restored the mspncp-patch-1 branch November 15, 2023 07:27
@mspncp
Copy link
Contributor Author

mspncp commented Nov 15, 2023

@arapov this was auto-closed by @openssl-machine without being merged, although it had an 'approval: done' label? How can this happen?

grafik

@mspncp mspncp reopened this Nov 15, 2023
@openssl-machine openssl-machine deleted the mspncp-patch-1 branch November 15, 2023 07:36
@t8m
Copy link
Member

t8m commented Nov 15, 2023

@mspncp because you created the branch in the openssl/openssl repo and not in your fork.

@t8m t8m restored the mspncp-patch-1 branch November 15, 2023 07:36
@t8m t8m reopened this Nov 15, 2023
@t8m
Copy link
Member

t8m commented Nov 15, 2023

I'll merge it now.

@t8m t8m added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Nov 15, 2023
@t8m
Copy link
Member

t8m commented Nov 15, 2023

Merged to the master and 3.2 branches. Thank you.

@t8m t8m closed this Nov 15, 2023
openssl-machine pushed a commit that referenced this pull request Nov 15, 2023
@mspncp @t8m
README: add link to OpenSSL 3.2 manual pages
4f0172c 
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #22625)
openssl-machine pushed a commit that referenced this pull request Nov 15, 2023
@mspncp @t8m
README: add link to OpenSSL 3.2 manual pages
1b83adc 
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #22625)

(cherry picked from commit 4f0172c)
@openssl-machine openssl-machine deleted the mspncp-patch-1 branch November 15, 2023 07:38
@mspncp
Copy link
Contributor Author

mspncp commented Nov 15, 2023

Ah ok, thanks for the hint! I wasn't aware of that. 😊
I guess this is the first and last time I'll do a quick PR via GitHub webinterface on my mobile phone! 📵

wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Nov 20, 2023
@mspncp
README: add link to OpenSSL 3.2 manual pages
910bb49 
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl/openssl#22625)

Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Nov 20, 2023
@mspncp
README: add link to OpenSSL 3.2 manual pages
f7c104c 
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl/openssl#22625)

(cherry picked from commit 4f0172c543dd0f5582d52185bfe2c132faee9c8e)
Signed-off-by: fly2x <fly2x@hitls.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@slontis slontis slontis approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.2 Merge to openssl-3.2 tests: exempted The PR is exempt from requirements for testing triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mspncp @t8m @levitte @slontis @openssl-machine