Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bad backport #22682

Closed
wants to merge 1 commit into from
Closed

Fix a bad backport #22682

wants to merge 1 commit into from

Conversation

mattcaswell
Copy link
Member

This is causing compilation failure

Marking as urgent.

@mattcaswell
Fix a bad backport
6c8a705 
This is causing compilation failure
@mattcaswell mattcaswell added approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member severity: urgent Fixes an urgent issue (exempt from 24h grace period) branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 labels Nov 9, 2023
This was referenced Nov 9, 2023
Closed
Closed
beldmit
beldmit approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agree urgent

t8m
t8m approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with urgent

@t8m t8m added approval: ready to merge The 24 hour grace period has passed, ready to merge triaged: bug The issue/pr is/fixes a bug and removed approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member labels Nov 9, 2023
@t8m
Copy link
Member

t8m commented Nov 9, 2023

Merged to the 3.1 and 3.0 branches. Thank you.

@t8m t8m closed this Nov 9, 2023
openssl-machine pushed a commit that referenced this pull request Nov 9, 2023
@mattcaswell @t8m
Fix a bad backport
75d57d0 
This is causing compilation failure

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #22682)

(cherry picked from commit 2fd4fd3)
openssl-machine pushed a commit that referenced this pull request Nov 9, 2023
@mattcaswell
Fix a bad backport
2fd4fd3 
This is causing compilation failure

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #22682)
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Nov 14, 2023
@mattcaswell
Fix a bad backport
cddd454 
This is causing compilation failure

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl/openssl#22682)

(cherry picked from commit 2fd4fd35bf906290a9c14b81f16e7ae01d297122)
Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Nov 14, 2023
@mattcaswell
Fix a bad backport
fc36942 
This is causing compilation failure

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl/openssl#22682)

Signed-off-by: fly2x <fly2x@hitls.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamuir jamuir jamuir approved these changes

@t8m t8m t8m approved these changes

@beldmit beldmit beldmit approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 severity: urgent Fixes an urgent issue (exempt from 24h grace period) triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mattcaswell @t8m @jamuir @beldmit