Introduce option allowing TLS 1.3 server to prefer psk_ke over psk_dhe_ke #22794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openssl-machine
added
the
hold: cla required
minichma
force-pushed
the
option_prefernodhkex
branch
from
46c15ee
to
65e805b
Compare
t8m
requested changes
Nov 22, 2023
t8m
added
branch: master
…non-dhe psk key exchange over psk with dhe (config file option `PreferNoDHEKEX`, server option `prefer_no_dhe_kex`).
minichma
force-pushed
the
option_prefernodhkex
branch
from
65e805b
to
09ef585
Compare
|
@t8m Thank you! Improved as suggested. As the doc build complained about docs missing in Btw, the CLA is on its way. |
|
I would keep it at the client docs. However you also need to add the description for the new command line option in SSL_CONF_cmd.pod around line 98 and mention there that it is ignored on client. |
minichma
force-pushed
the
option_prefernodhkex
branch
from
09ef585
to
216f2a6
Compare
t8m
added
approval: review pending
mattcaswell
removed
the
approval: otc review pending
openssl-machine
removed
the
hold: cla required
|
@t8m I closed and reopened the PR to get rid of the 'CLA missing' tag. I've added the changelog in anticipation of version 3.3. Anything else missing from my side? |
t8m
approved these changes
Nov 23, 2023
t8m
added
approval: done
Nope, this is good as is. |
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
mattcaswell
added
approval: ready to merge
|
Pushed. Thanks! |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 24, 2023
…non-dhe psk key exchange over psk with dhe (config file option `PreferNoDHEKEX`, server option `prefer_no_dhe_kex`). Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #22794)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 24, 2023
Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #22794)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 24, 2023
…L version 3.3. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #22794)
This was referenced Nov 24, 2023
wanghao75
pushed a commit
to openeuler-mirror/openssl
that referenced
this pull request
Dec 7, 2023
…non-dhe psk key exchange over psk with dhe (config file option `PreferNoDHEKEX`, server option `prefer_no_dhe_kex`). Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from openssl/openssl#22794) Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75
pushed a commit
to openeuler-mirror/openssl
that referenced
this pull request
Dec 7, 2023
Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from openssl/openssl#22794) Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75
pushed a commit
to openeuler-mirror/openssl
that referenced
this pull request
Dec 7, 2023
…L version 3.3. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from openssl/openssl#22794) Signed-off-by: fly2x <fly2x@hitls.org>
wbeck10
pushed a commit
to wbeck10/openssl
that referenced
this pull request
Jan 8, 2024
…non-dhe psk key exchange over psk with dhe (config file option `PreferNoDHEKEX`, server option `prefer_no_dhe_kex`). Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from openssl#22794)
wbeck10
pushed a commit
to wbeck10/openssl
that referenced
this pull request
Jan 8, 2024
Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from openssl#22794)
wbeck10
pushed a commit
to wbeck10/openssl
that referenced
this pull request
Jan 8, 2024
…L version 3.3. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from openssl#22794)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce option
SSL_OP_PREFER_NO_DHE_KEX, which allows configuring a TLS1.3 server to prefer session resumption using PSK-only key exchange over PSK with DHE, if both are available. The option is ignored unless PSK-only is explicitly allowed viaSSL_OP_ALLOW_NO_DHE_KEX.PreferNoDHEKEXprefer_no_dhe_kexThis PR addresses #22783.
Checklist
ToDo
SSL_CONF_cmd.pod.