Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize dstctx->mgf1_md to NULL in rsa_dupctx function #22795

Closed
wants to merge 0 commits into from
Closed

Initialize dstctx->mgf1_md to NULL in rsa_dupctx function #22795

wants to merge 0 commits into from

Conversation

lan1120
Copy link
Contributor

@lan1120 lan1120 commented Nov 22, 2023 •
edited

dstctx->mgf1_md should be set NULL in rsa_dupctx avoid releasing mgf1_md of srcctx when err occurs.

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Nov 22, 2023
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Nov 22, 2023
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Nov 22, 2023
@t8m
Copy link
Member

t8m commented Nov 22, 2023 •
edited

This would be acceptable with CLA: trivial. If you agree to submit it as such please amend the commit message to include CLA: trivial on a separate line. Or please submit a regular CLA.
https://www.openssl.org/policies/cla.html

I did not realize you already submitted a CLA.

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing branch: 3.2 Merge to openssl-3.2 labels Nov 22, 2023
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Nov 22, 2023
@tmshort tmshort added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Nov 29, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Nov 30, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Nov 30, 2023
@lan1120 @t8m
Initialize dstctx->mgf1_md to NULL in rsa_dupctx function
f95e3a0 
Signed-off-by: lan1120 <lanming@huawei.com>

Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #22795)
openssl-machine pushed a commit that referenced this pull request Nov 30, 2023
@lan1120 @t8m
Initialize dstctx->mgf1_md to NULL in rsa_dupctx function
18685a7 
Signed-off-by: lan1120 <lanming@huawei.com>

Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #22795)

(cherry picked from commit f95e3a0)
openssl-machine pushed a commit that referenced this pull request Nov 30, 2023
@lan1120 @t8m
Initialize dstctx->mgf1_md to NULL in rsa_dupctx function
eb19288 
Signed-off-by: lan1120 <lanming@huawei.com>

Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #22795)

(cherry picked from commit f95e3a0)
openssl-machine pushed a commit that referenced this pull request Nov 30, 2023
@lan1120 @t8m
Initialize dstctx->mgf1_md to NULL in rsa_dupctx function
4554f0b 
Signed-off-by: lan1120 <lanming@huawei.com>

Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #22795)

(cherry picked from commit f95e3a0)
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Dec 7, 2023
@lan1120
Initialize dstctx->mgf1_md to NULL in rsa_dupctx function
aad88d0 
Signed-off-by: lan1120 <lanming@huawei.com>

Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl/openssl#22795)

Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Dec 7, 2023
@lan1120
Initialize dstctx->mgf1_md to NULL in rsa_dupctx function
1f81028 
Signed-off-by: lan1120 <lanming@huawei.com>

Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl/openssl#22795)

(cherry picked from commit f95e3a09173b13dcfae668be6103e64c02222f08)
Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Dec 7, 2023
@lan1120
Initialize dstctx->mgf1_md to NULL in rsa_dupctx function
4366ffb 
Signed-off-by: lan1120 <lanming@huawei.com>

Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl/openssl#22795)

(cherry picked from commit f95e3a09173b13dcfae668be6103e64c02222f08)
Signed-off-by: fly2x <fly2x@hitls.org>
@github-actions github-actions bot removed the severity: fips change The pull request changes FIPS provider sources label Dec 8, 2023
@lan1120 lan1120 closed this Dec 8, 2023
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Dec 15, 2023
@lan1120
Initialize dstctx->mgf1_md to NULL in rsa_dupctx function
70e6bf7 
Signed-off-by: lan1120 <lanming@huawei.com>

Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl/openssl#22795)

(cherry picked from commit f95e3a09173b13dcfae668be6103e64c02222f08)
Signed-off-by: fly2x <fly2x@hitls.org>
wbeck10 pushed a commit to wbeck10/openssl that referenced this pull request Jan 8, 2024
@lan1120 @wbeck10p
Initialize dstctx->mgf1_md to NULL in rsa_dupctx function
485ffee 
Signed-off-by: lan1120 <lanming@huawei.com>

Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#22795)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@tmshort tmshort tmshort approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lan1120 @t8m @openssl-machine @tmshort