Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail the Configure script with no Configurations #22855

Closed
wants to merge 1 commit into from
Closed

Fail the Configure script with no Configurations #22855

wants to merge 1 commit into from

Conversation

8W9aG
Copy link
Contributor

@8W9aG 8W9aG commented Nov 29, 2023

  • Print a message about why the failure is happening.
  • Send the usage information.

See this discussion for more information: #22826

Checklist

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Nov 29, 2023
@t8m
Copy link
Member

t8m commented Nov 29, 2023

We will need a CLA to accept your contribution. Can you please sign it? https://www.openssl.org/policies/cla.html

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug tests: exempted The PR is exempt from requirements for testing labels Nov 29, 2023
@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Nov 29, 2023
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@openssl-machine
Copy link
Collaborator

This PR has the label 'hold: cla required' and is stale: it has not been updated in 31 days. Note that this PR may be automatically closed in the future if no CLA is provided. For CLA help see https://www.openssl.org/policies/cla.html

@InfoHunter
Copy link
Member

We will need a CLA to accept your contribution. Can you please sign it? https://www.openssl.org/policies/cla.html

Or could this be considered as trivial?

@t8m
Copy link
Member

t8m commented Jan 5, 2024

We will need a CLA to accept your contribution. Can you please sign it? https://www.openssl.org/policies/cla.html

Or could this be considered as trivial?

Unfortunately this is outside of what we can accept with CLA: trivial.

@8W9aG
Copy link
Contributor Author

8W9aG commented Jan 5, 2024

I have signed the CLA, let me see if it executes once I rebase

@8W9aG
Fail the Configure script with no Configurations
ad480f9 
* Print a message about why the failure is
happening.
* Send the usage information.
@8W9aG 8W9aG force-pushed the add-configurations-fail-err branch from 44f0521 to ad480f9 Compare January 5, 2024 13:59
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Jan 5, 2024
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: done This pull request has the required number of approvals labels Jan 5, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jan 6, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Jan 8, 2024

Merged to the master branch. Thank you for your contribution.

@t8m t8m closed this Jan 8, 2024
openssl-machine pushed a commit that referenced this pull request Jan 8, 2024
@8W9aG @t8m
Fail the Configure script with no Configurations
0a22436 
* Print a message about why the failure is
happening.
* Send the usage information.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #22855)
wbeck10 pushed a commit to wbeck10/openssl that referenced this pull request Jan 8, 2024
@8W9aG @wbeck10p
Fail the Configure script with no Configurations
ddb319d 
* Print a message about why the failure is
happening.
* Send the usage information.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl#22855)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@8W9aG @t8m @openssl-machine @InfoHunter @levitte @mattcaswell