Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct traces for certificates in dtls13 #22935

Closed
wants to merge 1 commit into from
Closed

Correct traces for certificates in dtls13 #22935

wants to merge 1 commit into from

Conversation

fwh-dc
Copy link
Contributor

@fwh-dc fwh-dc commented Dec 4, 2023

Checklist

@fwh-dc fwh-dc mentioned this pull request Dec 4, 2023
Closed
@t8m t8m added this to the DTLS-1.3 milestone Dec 4, 2023
@fwh-dc fwh-dc changed the base branch from master to feature/dtls-1.3 March 21, 2024 13:00
@fwh-dc fwh-dc closed this Mar 21, 2024
@fwh-dc fwh-dc reopened this Mar 21, 2024
@fwh-dc
Copy link
Contributor Author

fwh-dc commented Mar 21, 2024

@t8m This is ready for review. Would you please add labels to reflect that? Thanks!

@nhorman nhorman mentioned this pull request Apr 3, 2024
Open
t8m
t8m requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase to apply the new macro.

@t8m t8m added approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: feature The issue/pr requests/adds a feature tests: deferred Tests will be added in a subsequent PR (label should be removed when the PR with tests is merged) labels Apr 4, 2024
@fwh-dc fwh-dc force-pushed the support-dtls13-in-cert-trace-functions branch from d82bea9 to 24bf21d Compare April 8, 2024 11:42
@openssl-machine openssl-machine force-pushed the feature/dtls-1.3 branch 2 times, most recently from fbea037 to 553fcfb Compare April 23, 2024 11:08
@fwh-dc fwh-dc force-pushed the support-dtls13-in-cert-trace-functions branch from 24bf21d to 91a91f8 Compare May 2, 2024 19:02
@fwh-dc
Copy link
Contributor Author

fwh-dc commented May 2, 2024

Needs rebase to apply the new macro.

Done.

@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label May 6, 2024
@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 13, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels May 14, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented May 14, 2024

Merged to the feature branch. Thank you for your contribution.

@t8m t8m closed this May 14, 2024
openssl-machine pushed a commit that referenced this pull request May 14, 2024
@fwh-dc @t8m
Correct traces for certificates in dtls13
5b536e9 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #22935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge tests: deferred Tests will be added in a subsequent PR (label should be removed when the PR with tests is merged) triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Milestone
DTLS-1.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fwh-dc @openssl-machine @t8m @mattcaswell