Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix provider compatibility check crash in evp_test [3.0] #23009

Closed
wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Dec 11, 2023

EVP_MAC_CTX_get_mac_size() cannot be called on older unfixed versions before EVP_MAC_init().

Same as #23006 but for 3.0 branch.

Checklist
  • tests are added or updated

EVP_MAC_CTX_get_mac_size() cannot be called on older
unfixed versions before EVP_MAC_init().
@t8m t8m added approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch tests: exempted The PR is exempt from requirements for testing labels Dec 11, 2023
@t8m t8m requested a review from jamuir December 11, 2023 14:53
@t8m t8m changed the title Fix provider compatibility check crash in evp_test Fix provider compatibility check crash in evp_test [3.0] Dec 11, 2023
@mattcaswell mattcaswell removed the approval: otc review pending This pull request needs review by an OTC member label Dec 12, 2023
@t8m t8m requested a review from nhorman December 12, 2023 15:38
@t8m t8m added the severity: regression The issue/pr is a regression from previous released version label Dec 12, 2023
@t8m t8m requested review from levitte and hlandau December 12, 2023 19:09
@slontis slontis added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Dec 14, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 15, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member Author

t8m commented Dec 15, 2023

Merged to the 3.0 branch. Thank you for the reviews.

@t8m t8m closed this Dec 15, 2023
openssl-machine pushed a commit that referenced this pull request Dec 15, 2023
EVP_MAC_CTX_get_mac_size() cannot be called on older
unfixed versions before EVP_MAC_init().

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #23009)
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Dec 22, 2023
EVP_MAC_CTX_get_mac_size() cannot be called on older
unfixed versions before EVP_MAC_init().

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl/openssl#23009)

Signed-off-by: lanming1120 <lanming1120@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: 3.0 Merge to openssl-3.0 branch severity: regression The issue/pr is a regression from previous released version tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants