Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds design document for DTLS 1.3 implementation documentation #23041

Closed
wants to merge 5 commits into from
Closed

Adds design document for DTLS 1.3 implementation documentation #23041

wants to merge 5 commits into from

Conversation

fwh-dc
Copy link
Contributor

@fwh-dc fwh-dc commented Dec 14, 2023

Checklist
  • documentation is added or updated
  • tests are added or updated

@fwh-dc fwh-dc mentioned this pull request Dec 14, 2023
Closed
@t8m t8m added branch: master Merge to master branch triaged: design The issue/pr deals with a design document labels Dec 14, 2023
@t8m t8m added this to the DTLS-1.3 milestone Dec 14, 2023
mattcaswell
mattcaswell approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@mattcaswell mattcaswell added approval: review pending This pull request needs review by a committer tests: exempted The PR is exempt from requirements for testing labels Dec 18, 2023
@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 61 days ago

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 92 days ago

@fwh-dc fwh-dc changed the base branch from master to feature/dtls-1.3 March 21, 2024 13:02
@fwh-dc fwh-dc closed this Mar 21, 2024
@fwh-dc fwh-dc reopened this Mar 21, 2024
@nhorman nhorman mentioned this pull request Apr 3, 2024
Open
@t8m
Copy link
Member

t8m commented Apr 4, 2024

The check_docs CI failure is relevant.

@t8m
Copy link
Member

t8m commented Apr 9, 2024

@mattcaswell please reconfirm

@davidben
Copy link
Contributor

A few TLSWG threads to call to your attention. As we've been reviewing the documents, we noticed a few hiccups in parts of the protocol:
https://mailarchive.ietf.org/arch/msg/tls/6y8wTv8Q_IPM-PCcbCAmDOYg6bM/
https://mailarchive.ietf.org/arch/msg/tls/3IEIzc2ssdkZbyYEXIvz6t3ZhbI/
https://mailarchive.ietf.org/arch/msg/tls/_ku3-YDcroNmG_QKZsYTtqYzC0M/
https://mailarchive.ietf.org/arch/msg/tls/GYX_teYy5CTFiGCBgbQJQwv_Fj4/

(Thoughts welcome on the TLSWG list.)

@openssl-machine openssl-machine force-pushed the feature/dtls-1.3 branch 2 times, most recently from fbea037 to 553fcfb Compare April 23, 2024 11:08
@t8m
Copy link
Member

t8m commented May 14, 2024

doc check CI is relevant

@fwh-dc fwh-dc requested review from t8m and mattcaswell May 15, 2024 06:26
mattcaswell
mattcaswell requested changes May 15, 2024
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just one very minor typo

doc/designs/dtlsv1_3/dtlsv1_3-main.md Outdated Show resolved Hide resolved
@t8m
Copy link
Member

t8m commented May 17, 2024

Still OK

@t8m t8m requested a review from mattcaswell May 17, 2024 06:52
@fwh-dc
Copy link
Contributor Author

fwh-dc commented May 21, 2024

@mattcaswell please confirm :)

@fwh-dc
Copy link
Contributor Author

fwh-dc commented May 24, 2024

ping @mattcaswell

@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 29, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels May 30, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented May 30, 2024

Squashed and merged to the feature branch. Thank you for your contribution.

@t8m t8m closed this May 30, 2024
openssl-machine pushed a commit that referenced this pull request May 30, 2024
@fwh-dc @t8m
Add design document for DTLS 1.3 implementation
4128393 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23041)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch tests: exempted The PR is exempt from requirements for testing triaged: design The issue/pr deals with a design document
Projects
None yet
Milestone
DTLS-1.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fwh-dc @openssl-machine @t8m @davidben @mattcaswell