Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify ssl/tls/dtls version checks #23163

Closed
wants to merge 2 commits into from
Closed

Simplify ssl/tls/dtls version checks #23163

wants to merge 2 commits into from

Conversation

fwh-dc
Copy link
Contributor

@fwh-dc fwh-dc commented Dec 29, 2023

This PR aims to simplify version checks throughout the codebase by using the version_cmp() function of statem_lib.c.

t8m
t8m requested changes Dec 29, 2023
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring. Just one style nit.

ssl/statem/statem_clnt.c Show resolved Hide resolved
@t8m t8m added branch: master Merge to master branch triaged: refactor The issue/pr requests/implements refactoring tests: exempted The PR is exempt from requirements for testing labels Dec 29, 2023
@t8m t8m added the approval: review pending This pull request needs review by a committer label Jan 2, 2024
@t8m
Copy link
Member

t8m commented Jan 2, 2024

I've reported the unrelated CI failure as #23176

mattcaswell
mattcaswell approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jan 2, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jan 3, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Jan 3, 2024
@fwh-dc @mattcaswell
Simplify ssl protocol version comparisons.
6fd3794 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #23163)
@mattcaswell
Copy link
Member

Pushed to master. Thanks!

@mattcaswell mattcaswell closed this Jan 3, 2024
wbeck10 pushed a commit to wbeck10/openssl that referenced this pull request Jan 8, 2024
@fwh-dc @wbeck10p
Simplify ssl protocol version comparisons.
f8878ca 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl#23163)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch tests: exempted The PR is exempt from requirements for testing triaged: refactor The issue/pr requests/implements refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fwh-dc @t8m @openssl-machine @mattcaswell