Fix a possible memory leak in sxnet_v2i #23234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a subsequent call to SXNET_add_id_asc fails e.g. because user is a string larger than 64 char or the zone is a duplicate zone id, or the zone is not an integer, a memory leak may be the result.
bernd-edlinger
added
branch: master
t8m
approved these changes
Jan 8, 2024
t8m
added
approval: review pending
|
I believe this is a duplicate of #23211 |
I do not think it is. |
mattcaswell
approved these changes
Jan 9, 2024
mattcaswell
added
approval: done
|
Hmm, while trying to add a test case I hit another incredibly stupid memory leak.... |
Even in the good case there was memory leak here. Add a simple test case to have at least some test coverage.
|
Okay, I added a test case, and fixed the other memory leak too. Thanks! |
mattcaswell
added
approval: review pending
t8m
added
tests: present
t8m
approved these changes
Jan 9, 2024
t8m
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Jan 10, 2024
When a subsequent call to SXNET_add_id_asc fails e.g. because user is a string larger than 64 char or the zone is a duplicate zone id, or the zone is not an integer, a memory leak may be the result. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #23234)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 10, 2024
Even in the good case there was memory leak here. Add a simple test case to have at least some test coverage. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #23234)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 10, 2024
When a subsequent call to SXNET_add_id_asc fails e.g. because user is a string larger than 64 char or the zone is a duplicate zone id, or the zone is not an integer, a memory leak may be the result. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #23234) (cherry picked from commit 0151e77)
|
Merged to the master, 3.2, 3.1, and 3.0 branches. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Jan 10, 2024
When a subsequent call to SXNET_add_id_asc fails e.g. because user is a string larger than 64 char or the zone is a duplicate zone id, or the zone is not an integer, a memory leak may be the result. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #23234) (cherry picked from commit 0151e77)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 10, 2024
When a subsequent call to SXNET_add_id_asc fails e.g. because user is a string larger than 64 char or the zone is a duplicate zone id, or the zone is not an integer, a memory leak may be the result. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #23234) (cherry picked from commit 0151e77)
bernd-edlinger
added a commit
to bernd-edlinger/openssl
that referenced
this pull request
Jan 11, 2024
When a subsequent call to SXNET_add_id_asc fails e.g. because user is a string larger than 64 char or the zone is a duplicate zone id, or the zone is not an integer, a memory leak may be the result. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#23234) (cherry picked from commit 0151e77)
bernd-edlinger
added a commit
to bernd-edlinger/openssl
that referenced
this pull request
Jan 11, 2024
Even in the good case there was memory leak here. Add a simple test case to have at least some test coverage. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#23234) (cherry picked from commit 3980118)
bernd-edlinger
added a commit
to bernd-edlinger/openssl
that referenced
this pull request
Jan 11, 2024
When a subsequent call to SXNET_add_id_asc fails e.g. because user is a string larger than 64 char or the zone is a duplicate zone id, or the zone is not an integer, a memory leak may be the result. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#23234) (cherry picked from commit 0151e77)
bernd-edlinger
added a commit
to bernd-edlinger/openssl
that referenced
this pull request
Jan 11, 2024
Even in the good case there was memory leak here. Add a simple test case to have at least some test coverage. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#23234) (cherry picked from commit 3980118)
bernd-edlinger
added a commit
to bernd-edlinger/openssl
that referenced
this pull request
Jan 11, 2024
When a subsequent call to SXNET_add_id_asc fails e.g. because user is a string larger than 64 char or the zone is a duplicate zone id, or the zone is not an integer, a memory leak may be the result. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#23234) (cherry picked from commit 0151e77)
bernd-edlinger
added a commit
to bernd-edlinger/openssl
that referenced
this pull request
Jan 11, 2024
Even in the good case there was memory leak here. Add a simple test case to have at least some test coverage. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#23234) (cherry picked from commit 3980118)
bernd-edlinger
added a commit
to bernd-edlinger/openssl
that referenced
this pull request
Jan 11, 2024
When a subsequent call to SXNET_add_id_asc fails e.g. because user is a string larger than 64 char or the zone is a duplicate zone id, or the zone is not an integer, a memory leak may be the result. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#23234) (cherry picked from commit 0151e77)
bernd-edlinger
added a commit
to bernd-edlinger/openssl
that referenced
this pull request
Jan 11, 2024
Even in the good case there was memory leak here. Add a simple test case to have at least some test coverage. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#23234) (cherry picked from commit 3980118)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a subsequent call to SXNET_add_id_asc fails
e.g. because user is a string larger than 64 char
or the zone is a duplicate zone id,
or the zone is not an integer,
a memory leak may be the result.
Checklist