Add apps/x509 -set_issuer option #23257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhorman
reviewed
Jan 10, 2024
nhorman
approved these changes
Jan 10, 2024
slontis
reviewed
Jan 11, 2024
t8m
requested changes
Jan 11, 2024
t8m
added
branch: master
t8m
reviewed
Jan 11, 2024
t8m
approved these changes
Jan 11, 2024
t8m
removed
the
approval: otc review pending
|
I squashed the commits into a single one |
…subject This changeset adds the counterpart to the '-subj' option to allow overriding the Issuer. For consistency, the `-subj` option is aliased to `-set_subject`. The issuer can be specified as following apps/openssl x509 -new -set_issuer '/CN=example-nro-ta' -subj '/CN=2a7dd1d787d793e4c8af56e197d4eed92af6ba13' ... This is useful in constructing specific test-cases or rechaining PKI trees Joint work with George Michaelson (@geeohgeegeeoh)
slontis
approved these changes
Jan 12, 2024
slontis
added
approval: done
t8m
approved these changes
Jan 12, 2024
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to the master branch. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Jan 15, 2024
…subject This changeset adds the counterpart to the '-subj' option to allow overriding the Issuer. For consistency, the `-subj` option is aliased to `-set_subject`. The issuer can be specified as following apps/openssl x509 -new -set_issuer '/CN=example-nro-ta' -subj '/CN=2a7dd1d787d793e4c8af56e197d4eed92af6ba13' ... This is useful in constructing specific test-cases or rechaining PKI trees Joint work with George Michaelson (@geeohgeegeeoh) Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #23257)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds the counterpart to the '-subj' option to allow overriding the Issuer.
The issuer can be specified as following:
apps/openssl x509 -new -set_issuer '/CN=example-nro-ta' -subj '/CN=2a7dd1d787d793e4c8af56e197d4eed92af6ba13' ...This is useful in constructing specific test-cases or rechaining PKI trees
Joint work with @geeohgeegeeoh
A continuation of #23047 - now with CLAs in place.
Checklist