Add atexit configuration option to control using atexit() in libcrypto at build-time. #23394
+49
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsbeckerca
changed the title
rsbeckerca
changed the title
|
Note that you can already control this at run time via |
mattcaswell
requested changes
Jan 26, 2024
Runtime is not really an option. There are hundreds of applications deployed using OpenSSL that would all require modification. High-impact changes like this would be problematic. This was briefly commented on in #23135 . |
rsbeckerca
force-pushed
the
fix-23135-alt
branch
from
0d432cb
to
cebaa49
Compare
rsbeckerca
changed the title
rsbeckerca
changed the title
|
This PR passed all regression tests/checks and is ready for review again. |
nhorman
approved these changes
Jan 26, 2024
mattcaswell
requested changes
Jan 29, 2024
| @@ -420,6 +420,7 @@ my @disablables = ( | |||
| "asan", | |||
| "asm", | |||
| "async", | |||
| "atexit", | |||
There was a problem hiding this comment.
This new option should additionally be documented in the INSTALL.md file since it applies to all platforms. I think it also justifies a CHANGES.md entry.
There was a problem hiding this comment.
Will be there on the next push.
There was a problem hiding this comment.
Updates done. Thank you for your feedback.
mattcaswell
added
branch: master
|
Probably, it should also have an entry in .github/workflows/run-checker-daily.yml |
I have added a |
rsbeckerca
force-pushed
the
fix-23135-alt
branch
from
cebaa49
to
d36837b
Compare
…ld-time. This fixes an issue with a mix of atexit() usage in DLL and statically linked libcrypto that came out in the test suite on NonStop, which has slightly different DLL unload processing semantics compared to Linux. The change allows a build configuration to select whether to register OPENSSL_cleanup() with atexit() or not, so avoid situations where atexit() registration causes SIGSEGV. INSTALL.md and CHANGES.md have been modified to include and describe this option. The no-atexit option has been added to .github/workflows/run-checker-daily.yml. Fixes: openssl#23135 Signed-of-by: Randall S. Becker <randall.becker@nexbridge.ca>
rsbeckerca
force-pushed
the
fix-23135-alt
branch
from
d36837b
to
f72b746
Compare
mattcaswell
added
tests: present
mattcaswell
approved these changes
Jan 29, 2024
mattcaswell
added
approval: review pending
|
@nhorman - please reconfirm |
|
approval reconfirmed. |
mattcaswell
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to |
openssl-machine
pushed a commit
that referenced
this pull request
Feb 2, 2024
…ld-time. This fixes an issue with a mix of atexit() usage in DLL and statically linked libcrypto that came out in the test suite on NonStop, which has slightly different DLL unload processing semantics compared to Linux. The change allows a build configuration to select whether to register OPENSSL_cleanup() with atexit() or not, so avoid situations where atexit() registration causes SIGSEGV. INSTALL.md and CHANGES.md have been modified to include and describe this option. The no-atexit option has been added to .github/workflows/run-checker-daily.yml. Fixes: #23135 Signed-of-by: Randall S. Becker <randall.becker@nexbridge.ca> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Todd Short <todd.short@me.com> (Merged from #23394)
Sashan
pushed a commit
to Sashan/openssl
that referenced
this pull request
Feb 12, 2024
…ld-time. This fixes an issue with a mix of atexit() usage in DLL and statically linked libcrypto that came out in the test suite on NonStop, which has slightly different DLL unload processing semantics compared to Linux. The change allows a build configuration to select whether to register OPENSSL_cleanup() with atexit() or not, so avoid situations where atexit() registration causes SIGSEGV. INSTALL.md and CHANGES.md have been modified to include and describe this option. The no-atexit option has been added to .github/workflows/run-checker-daily.yml. Fixes: openssl#23135 Signed-of-by: Randall S. Becker <randall.becker@nexbridge.ca> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Todd Short <todd.short@me.com> (Merged from openssl#23394)
|
OTC vote has passed: openssl/technical-policies#89 This can be backported to 3.0, 3.1 and 3.2 (without the NonStop changes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with a mix of atexit() usage in DLL and statically linked libcrypto that came out in the test suite on NonStop, which has slightly different DLL unload processing semantics compared to Linux. The change allows a build configuration to select whether to register OPENSSL_cleanup() with atexit() or not, so avoid situations where atexit() registration causes SIGSEGV.
INSTALL.md and CHANGES.md have been modified to include and describe this
option.
The no-atexit option has been added to .github/workflows/run-checker-daily.yml.
Fixes: #23135
Signed-of-by: Randall S. Becker randall.becker@nexbridge.ca
Checklist