Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-one in ebcdic2ascii() #23404

Closed
wants to merge 1 commit into from
Closed

Fix off-by-one in ebcdic2ascii() #23404

wants to merge 1 commit into from

Conversation

coolshrid
Copy link
Contributor

@coolshrid coolshrid commented Jan 27, 2024 •
edited by tom-cosgrove-arm

Fixes #23363

Checklist
  • documentation is added or updated
  • tests are added or updated

@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Jan 29, 2024
@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing branch: 3.2 Merge to openssl-3.2 labels Jan 29, 2024
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Jan 29, 2024
@t8m
Copy link
Member

t8m commented Jan 29, 2024

Next time, please use more descriptive commit message title such as

Fix off by one issue in buf2hexstr_sep()

Fixes #23363

We can correct this when merging.

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

@tom-cosgrove-arm tom-cosgrove-arm changed the title Fixes for issue #23363 Fix off-by-one in ebcdic2ascii() Feb 29, 2024
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 29, 2024
@tom-cosgrove-arm tom-cosgrove-arm mentioned this pull request Feb 29, 2024
Closed
2 tasks
@tom-cosgrove-arm
Copy link
Contributor

Note for whoever does the merge: we need to update the commit message

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@t8m
Copy link
Member

t8m commented Mar 1, 2024

Merged to the master, 3.2, 3.1 and 3.0 branches. Thank you for your contribution.

@t8m t8m closed this Mar 1, 2024
openssl-machine pushed a commit that referenced this pull request Mar 1, 2024
@coolshrid @t8m
Fix off by one issue in buf2hexstr_sep()
c5cc9c4 
Fixes #23363

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23404)
openssl-machine pushed a commit that referenced this pull request Mar 1, 2024
@coolshrid @t8m
Fix off by one issue in buf2hexstr_sep()
d44aa28 
Fixes #23363

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23404)

(cherry picked from commit c5cc9c4)
openssl-machine pushed a commit that referenced this pull request Mar 1, 2024
@coolshrid @t8m
Fix off by one issue in buf2hexstr_sep()
cd10254 
Fixes #23363

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23404)

(cherry picked from commit c5cc9c4)
openssl-machine pushed a commit that referenced this pull request Mar 1, 2024
@coolshrid @t8m
Fix off by one issue in buf2hexstr_sep()
0c78270 
Fixes #23363

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23404)

(cherry picked from commit c5cc9c4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 severity: fips change The pull request changes FIPS provider sources tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

buf2hexstr_sep ebcdic2ascii translation off by 1
4 participants
@coolshrid @t8m @openssl-machine @tom-cosgrove-arm