Fix compilation on Windows using icc #23415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcaswell
added
branch: master
|
@UlrichKamke can you confirm that this patch fixes the build and that the tests still pass? |
The parameter list for CRYPTO_DOWN_REF for the icc on windows build was incorrect. This issue was introduced by 99fd5b2 Fixes openssl#23414
mattcaswell
force-pushed
the
fix-icc-windows
branch
from
00e026c
to
82f9682
Compare
github-actions
bot
added
the
severity: fips change
levitte
approved these changes
Jan 29, 2024
levitte
removed
the
approval: otc review pending
hlandau
approved these changes
Jan 29, 2024
hlandau
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Hello Matt, why do you merged your fix from #23414 not in the release 3.2.1? So we could use an official stable version 3.2.1. Your patch 23414 works for us. |
We were in code freeze from last week due to the release. This fix didn't hit "ready-to-merge" status until too late, so missed the 3.2.1 release. It will be merged soon and will be available in 3.2.2. |
|
Pushed to master/3.2. |
Sashan
pushed a commit
to Sashan/openssl
that referenced
this pull request
Feb 12, 2024
The parameter list for CRYPTO_DOWN_REF for the icc on windows build was incorrect. This issue was introduced by 99fd5b2 Fixes openssl#23414 Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Hugo Landau <hlandau@openssl.org> (Merged from openssl#23415)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter list for CRYPTO_DOWN_REF for the icc on windows build was incorrect.
This issue was introduced by 99fd5b2
Note I do not have access to this environment to test this...
Fixes #23414