Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync pyca workflow with master #23444

Closed
wants to merge 1 commit into from
Closed

Sync pyca workflow with master #23444

wants to merge 1 commit into from
+1 −1

Conversation

bernd-edlinger
Copy link
Member

This seems to fix the external pyca CI workflow for 3.1 and 3.0.
Some background can be found here: pyca/cryptography#10310

@bernd-edlinger bernd-edlinger added branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 labels Jan 31, 2024
@t8m t8m added approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug severity: urgent Fixes an urgent issue (exempt from 24h grace period) tests: exempted The PR is exempt from requirements for testing labels Jan 31, 2024
t8m
t8m approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. IMO it is urgent as the CI on 3.1 and 3.0 is now broken.

@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Jan 31, 2024
tmshort
tmshort approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmshort tmshort added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 2, 2024
openssl-machine pushed a commit that referenced this pull request Feb 2, 2024
@bernd-edlinger @tmshort
Sync pyca workflow with master
3b62e03 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from #23444)
@tmshort tmshort self-assigned this Feb 2, 2024
@tmshort
Copy link
Contributor

tmshort commented Feb 2, 2024

Merging now to openssl-3.1 and openssl-3.0 due to (severity: urgent)
Thank you for your contribution!

@tmshort tmshort closed this Feb 2, 2024
@tmshort tmshort added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Feb 2, 2024
openssl-machine pushed a commit that referenced this pull request Feb 2, 2024
@bernd-edlinger @tmshort
Sync pyca workflow with master
87564fe 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from #23444)

(cherry picked from commit 3b62e03)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@tmshort tmshort tmshort approved these changes

Assignees

@tmshort tmshort

Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 severity: urgent Fixes an urgent issue (exempt from 24h grace period) tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bernd-edlinger @tmshort @t8m