Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a missing space in an error message #23481

Closed
wants to merge 1 commit into from

Conversation

vinc17fr
Copy link
Contributor

@vinc17fr vinc17fr commented Feb 5, 2024

For the error message about "skipping %s,it does not contain exactly one certificate or CRL", add a missing space between the comma and the word that follows.

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Feb 5, 2024
@vinc17fr
Copy link
Contributor Author

vinc17fr commented Feb 5, 2024

This is a trivial change. There is no need for a CLA in such a case.

Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree trivial

@mattcaswell
Copy link
Member

@vinc17fr - please could you modify the commit message to add "CLA: trivial" on a line on its own in the commit description?

@mattcaswell mattcaswell added branch: master Merge to master branch approval: review pending This pull request needs review by a committer cla: trivial One of the commits is marked as 'CLA: trivial' tests: exempted The PR is exempt from requirements for testing labels Feb 5, 2024
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with CLA: trivial

@t8m t8m added triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 5, 2024
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Feb 5, 2024
@vinc17fr
Copy link
Contributor Author

vinc17fr commented Feb 5, 2024

@vinc17fr - please could you modify the commit message to add "CLA: trivial" on a line on its own in the commit description?

I've just pushed the commit with this "CLA: trivial" line.

@mattcaswell
Copy link
Member

I've just pushed the commit with this "CLA: trivial" line.

Perfect - thanks.

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@t8m
Copy link
Member

t8m commented Feb 6, 2024

Merged to the master branch. Thank you for your contribution.

@t8m t8m closed this Feb 6, 2024
openssl-machine pushed a commit that referenced this pull request Feb 6, 2024
CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23481)
@vinc17fr vinc17fr deleted the patch-1 branch February 6, 2024 11:58
Sashan pushed a commit to Sashan/openssl that referenced this pull request Feb 12, 2024
CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#23481)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial' tests: exempted The PR is exempt from requirements for testing triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants