Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend CHANGES.md/NEWS.md to reflect DN ouptut changes #23507

Closed
wants to merge 2 commits into from
Closed

Amend CHANGES.md/NEWS.md to reflect DN ouptut changes #23507

wants to merge 2 commits into from

Conversation

beldmit
Copy link
Member

@beldmit beldmit commented Feb 7, 2024

Fixes #23492

Checklist
  • documentation is added or updated
  • tests are added or updated

@beldmit beldmit added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member branch: 3.2 Merge to openssl-3.2 labels Feb 7, 2024
@beldmit
Copy link
Member Author

beldmit commented Feb 7, 2024

Could any native speaker please review the proposed change?

@t8m t8m added triaged: documentation The issue/pr deals with documentation (errors) tests: exempted The PR is exempt from requirements for testing labels Feb 7, 2024
mattcaswell
mattcaswell reviewed Feb 7, 2024
View reviewed changes
CHANGES.md Outdated
@@ -517,7 +517,7 @@ OpenSSL 3.2
*Paul Dale*

* Subject or issuer names in X.509 objects are now displayed as UTF-8 strings
by default.
by default. Also spaces surrounding `=` in Subject output are removed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only for Subject, or also for Issuer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in all DNs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok...in that case the wording should be adjusted accordingly

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@beldmit
Copy link
Member Author

beldmit commented Feb 7, 2024

The failure seems irrelevant

tom-cosgrove-arm
tom-cosgrove-arm reviewed Feb 8, 2024
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit removed the approval: review pending This pull request needs review by a committer label Feb 8, 2024
@beldmit
Copy link
Member Author

beldmit commented Feb 8, 2024

@kroeckx does it look good for you?

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: otc review pending This pull request needs review by an OTC member labels Feb 8, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Feb 9, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Feb 9, 2024
@beldmit
Amend CHANGES.md/NEWS.md to reflect DN output changes
d8d1910 
Fixes #23492

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23507)
@beldmit
Copy link
Member Author

beldmit commented Feb 9, 2024

Merged to master and 3.2. Thanks!

@beldmit beldmit closed this Feb 9, 2024
@beldmit beldmit deleted the fix_23492 branch February 9, 2024 11:58
openssl-machine pushed a commit that referenced this pull request Feb 9, 2024
@beldmit
Amend CHANGES.md/NEWS.md to reflect DN output changes
351cfa7 
Fixes #23492

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23507)

(cherry picked from commit d8d1910)
Sashan pushed a commit to Sashan/openssl that referenced this pull request Feb 12, 2024
@beldmit @Sashan
Amend CHANGES.md/NEWS.md to reflect DN output changes
38dfb5b 
Fixes openssl#23492

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#23507)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell left review comments

@t8m t8m t8m approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.2 Merge to openssl-3.2 tests: exempted The PR is exempt from requirements for testing triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nameline default change causes output change
5 participants
@beldmit @openssl-machine @t8m @mattcaswell @tom-cosgrove-arm