Skip shlibload tests if no-atexit is configured #23523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the shared library load tests fail if no-atexit is configured. The entire test suite relies on atexit handling to indicate an at exit handler has run, by producing a file that the test recipe then reads. With no-atexit that never happens, and the test fails If no-atexit is specified, skip all the tests
nhorman
added
branch: master
t8m
added
approval: review pending
t8m
approved these changes
Feb 8, 2024
t8m
removed
the
approval: otc review pending
mattcaswell
approved these changes
Feb 13, 2024
mattcaswell
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to the master branch. Thank you. |
openssl-machine
pushed a commit
that referenced
this pull request
Feb 14, 2024
the shared library load tests fail if no-atexit is configured. The entire test suite relies on atexit handling to indicate an at exit handler has run, by producing a file that the test recipe then reads. With no-atexit that never happens, and the test fails If no-atexit is specified, skip all the tests Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #23523)
meeque
pushed a commit
to meeque/openssl
that referenced
this pull request
Feb 18, 2024
the shared library load tests fail if no-atexit is configured. The entire test suite relies on atexit handling to indicate an at exit handler has run, by producing a file that the test recipe then reads. With no-atexit that never happens, and the test fails If no-atexit is specified, skip all the tests Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#23523)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the shared library load tests fail if no-atexit is configured. The entire test suite relies on atexit handling to indicate an at exit handler has run, by producing a file that the test recipe then reads. With no-atexit that never happens, and the test fails
If no-atexit is specified, skip all the tests
Checklist