Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps/x509.c: No warning reading from stdin if redirected #23526

Closed
wants to merge 1 commit into from
Closed

apps/x509.c: No warning reading from stdin if redirected #23526

wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Feb 8, 2024

This breaks some scripts with 3.2 version.

Fixes #22893

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug severity: regression The issue/pr is a regression from previous released version tests: exempted The PR is exempt from requirements for testing branch: 3.2 Merge to openssl-3.2 labels Feb 8, 2024
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Feb 8, 2024
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm removed the approval: review pending This pull request needs review by a committer label Feb 9, 2024
@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

@t8m
Copy link
Member Author

t8m commented Mar 13, 2024

ping for an OTC review

@t8m t8m requested a review from a team March 13, 2024 17:56
beldmit
beldmit approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit added approval: done This pull request has the required number of approvals and removed approval: otc review pending This pull request needs review by an OTC member labels Mar 13, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Mar 14, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member Author

t8m commented Mar 15, 2024

Merged to the master and 3.2 branches. Thank you for the reviews.

@t8m t8m closed this Mar 15, 2024
openssl-machine pushed a commit that referenced this pull request Mar 15, 2024
@t8m
apps/x509.c: No warning reading from stdin if redirected
5c846d3 
Fixes #22893

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from #23526)
openssl-machine pushed a commit that referenced this pull request Mar 15, 2024
@t8m
apps/x509.c: No warning reading from stdin if redirected
52bdbb8 
Fixes #22893

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from #23526)

(cherry picked from commit 5c846d3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhorman nhorman nhorman approved these changes

@beldmit beldmit beldmit approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.2 Merge to openssl-3.2 severity: fips change The pull request changes FIPS provider sources severity: regression The issue/pr is a regression from previous released version tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gratuitous warnings for x509 when reading from stdin
5 participants
@t8m @openssl-machine @nhorman @beldmit @tom-cosgrove-arm