Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUIC: Fix SSL_ctrl on QSSOs #23581

Closed
wants to merge 2 commits into from
Closed

QUIC: Fix SSL_ctrl on QSSOs #23581

wants to merge 2 commits into from

Conversation

hlandau
Copy link
Member

@hlandau hlandau commented Feb 14, 2024

Fixes #23578

@hlandau hlandau added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug tests: present The PR has suitable tests present branch: 3.2 Merge to openssl-3.2 labels Feb 14, 2024
@hlandau hlandau self-assigned this Feb 14, 2024
@hlandau hlandau mentioned this pull request Feb 14, 2024
Closed
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Feb 14, 2024
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 14, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Feb 15, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Feb 16, 2024

Merged to the master and 3.2 branches. Thank you.

@t8m t8m closed this Feb 16, 2024
openssl-machine pushed a commit that referenced this pull request Feb 16, 2024
@hlandau @t8m
QUIC: Fix SSL_ctrl operation for QSSOs
5c16e9d 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23581)
openssl-machine pushed a commit that referenced this pull request Feb 16, 2024
@hlandau @t8m
QUIC: Test that SSL_ctrl, SSL_set_mode are routed correctly on QSSOs
28c7f52 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23581)
openssl-machine pushed a commit that referenced this pull request Feb 16, 2024
@hlandau @t8m
QUIC: Fix SSL_ctrl operation for QSSOs
6276899 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23581)

(cherry picked from commit 5c16e9d)
openssl-machine pushed a commit that referenced this pull request Feb 16, 2024
@hlandau @t8m
QUIC: Test that SSL_ctrl, SSL_set_mode are routed correctly on QSSOs
0ceda00 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23581)

(cherry picked from commit 28c7f52)
meeque pushed a commit to meeque/openssl that referenced this pull request Feb 18, 2024
@hlandau
QUIC: Fix SSL_ctrl operation for QSSOs
4accde5 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#23581)
meeque pushed a commit to meeque/openssl that referenced this pull request Feb 18, 2024
@hlandau
QUIC: Test that SSL_ctrl, SSL_set_mode are routed correctly on QSSOs
1250158 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#23581)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhorman nhorman nhorman approved these changes

@t8m t8m t8m approved these changes

@t-j-h t-j-h t-j-h approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@levitte levitte Awaiting requested review from levitte

Assignees

@hlandau hlandau

Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.2 Merge to openssl-3.2 tests: present The PR has suitable tests present triaged: bug The issue/pr is/fixes a bug
Projects
Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSL_set_mode(..., SSL_MODE_ENABLE_PARTIAL_WRITE) not working on quic stream
6 participants
@hlandau @openssl-machine @t8m @nhorman @t-j-h @mattcaswell