-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix eror: relocation truncated to fit: R_PPC64_REL14 (stub) against symbol `ChaCha20_ctr32_vsx_8x' #23618
Conversation
…ymbol `ChaCha20_ctr32_vsx_8x'
@@ -170,7 +170,9 @@ sub VSX_lane_ROUND_4x { | |||
.align 5 | |||
.ChaCha20_ctr32_vsx_p10: | |||
${UCMP}i $len,255 | |||
bgt ChaCha20_ctr32_vsx_8x | |||
ble .Not_greater_than_8x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing this..
As far as I can see this code was added 2 years old..
See f596bbe
Why is this only being flagged now? i.e. Why wouldn't this have been a problem for the original author?
How far away is the label? (it looks like conditional branches use 12 bits (4096)).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This remote jump issue is only triggered when linking openssl to a larger application with a static library.
For example #21286
I wonder if there is an easy way to test this in CI.. |
I don't know how to test it in CI at the moment either, I can only realize to test it in a real project. |
Could you please amend the actual commit message to contain the |
OK with CLA: trivial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ok with trivial
24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually. |
Merged to the master, 3.2 and 3.1 branches. Thank you for your contribution. |
Fix error: relocation truncated to fit: R_PPC64_REL14 (stub) against symbol `ChaCha20_ctr32_vsx_8x' CLA: trivial Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #23618)
This pr is used to fix link errors in the aes assembly algorithm under ppc64.
The following message is reported when connecting under ppc64:
Issues related to this pr #21286
Checklist
CLA: trivial