Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eror: relocation truncated to fit: R_PPC64_REL14 (stub) against symbol `ChaCha20_ctr32_vsx_8x' #23618

Closed
wants to merge 1 commit into from

Conversation

xicilion
Copy link
Contributor

@xicilion xicilion commented Feb 17, 2024

This pr is used to fix link errors in the aes assembly algorithm under ppc64.

The following message is reported when connecting under ppc64:

/works/fibjs/bin/Linux_ppc64_release/libopenssl.a(chachap10-ppc.s.o): in function `ChaCha20_ctr32_vsx_p10':
(.text+0x4): relocation truncated to fit: R_PPC64_REL14 (stub) against symbol `ChaCha20_ctr32_vsx_8x' defined in .text section in /works/fibjs/bin/Linux_ppc64_release/libopenssl.a(chachap10-ppc.s.o)

Issues related to this pr #21286

Checklist
  • documentation is added or updated
  • tests are added or updated

CLA: trivial

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Feb 17, 2024
@@ -170,7 +170,9 @@ sub VSX_lane_ROUND_4x {
.align 5
.ChaCha20_ctr32_vsx_p10:
${UCMP}i $len,255
bgt ChaCha20_ctr32_vsx_8x
ble .Not_greater_than_8x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this..
As far as I can see this code was added 2 years old..
See f596bbe
Why is this only being flagged now? i.e. Why wouldn't this have been a problem for the original author?

How far away is the label? (it looks like conditional branches use 12 bits (4096)).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This remote jump issue is only triggered when linking openssl to a larger application with a static library.
For example #21286

@slontis
Copy link
Member

slontis commented Feb 19, 2024

I wonder if there is an easy way to test this in CI..

@xicilion
Copy link
Contributor Author

I don't know how to test it in CI at the moment either, I can only realize to test it in a real project.

@t8m
Copy link
Member

t8m commented Feb 19, 2024

Could you please amend the actual commit message to contain the CLA: trivial annotation in the commit message body on a separate line?

@t8m
Copy link
Member

t8m commented Feb 19, 2024

OK with CLA: trivial

@t8m t8m added approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug cla: trivial One of the commits is marked as 'CLA: trivial' branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing branch: 3.2 Merge to openssl-3.2 labels Feb 19, 2024
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ok with trivial

@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 21, 2024
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@t8m t8m added the branch: master Merge to master branch label Feb 22, 2024
@t8m
Copy link
Member

t8m commented Feb 22, 2024

Merged to the master, 3.2 and 3.1 branches. Thank you for your contribution.

@t8m t8m closed this Feb 22, 2024
openssl-machine pushed a commit that referenced this pull request Feb 22, 2024
Fix error: relocation truncated to fit: R_PPC64_REL14 (stub)
against symbol `ChaCha20_ctr32_vsx_8x'

CLA: trivial

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23618)

(cherry picked from commit 1afb326)
openssl-machine pushed a commit that referenced this pull request Feb 22, 2024
Fix error: relocation truncated to fit: R_PPC64_REL14 (stub)
against symbol `ChaCha20_ctr32_vsx_8x'

CLA: trivial

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23618)

(cherry picked from commit 1afb326)
openssl-machine pushed a commit that referenced this pull request Feb 22, 2024
Fix error: relocation truncated to fit: R_PPC64_REL14 (stub)
against symbol `ChaCha20_ctr32_vsx_8x'

CLA: trivial

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23618)
@xicilion xicilion deleted the patch-3 branch February 22, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 cla: trivial One of the commits is marked as 'CLA: trivial' hold: cla required The contributor needs to submit a license agreement tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants