Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't print excessively long ASN1 items in fuzzer #23640

Closed
wants to merge 1 commit into from
Closed

Don't print excessively long ASN1 items in fuzzer #23640

wants to merge 1 commit into from

Conversation

mattcaswell
Copy link
Member

Prevent spurious fuzzer timeouts by not printing ASN1 which is excessively long.

This fixes a false positive encountered by OSS-Fuzz.

@mattcaswell
Don't print excessively long ASN1 items in fuzzer
ef8f2b2 
Prevent spurious fuzzer timeouts by not printing ASN1 which is excessively
long.

This fixes a false positive encountered by OSS-Fuzz.
@mattcaswell mattcaswell added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing branch: 3.2 Merge to openssl-3.2 labels Feb 20, 2024
@t8m t8m added the triaged: bug The issue/pr is/fixes a bug label Feb 20, 2024
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Feb 20, 2024
@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 20, 2024
shahsb
shahsb approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@shahsb shahsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Feb 21, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Feb 21, 2024
@mattcaswell
Don't print excessively long ASN1 items in fuzzer
4a6f70c 
Prevent spurious fuzzer timeouts by not printing ASN1 which is excessively
long.

This fixes a false positive encountered by OSS-Fuzz.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
(Merged from #23640)
openssl-machine pushed a commit that referenced this pull request Feb 21, 2024
@mattcaswell
Don't print excessively long ASN1 items in fuzzer
c8dd22a 
Prevent spurious fuzzer timeouts by not printing ASN1 which is excessively
long.

This fixes a false positive encountered by OSS-Fuzz.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
(Merged from #23640)

(cherry picked from commit 4a6f70c)
openssl-machine pushed a commit that referenced this pull request Feb 21, 2024
@mattcaswell
Don't print excessively long ASN1 items in fuzzer
94f9ae9 
Prevent spurious fuzzer timeouts by not printing ASN1 which is excessively
long.

This fixes a false positive encountered by OSS-Fuzz.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
(Merged from #23640)

(cherry picked from commit 4a6f70c)
@mattcaswell
Copy link
Member Author

Pushed to master/3.2/3.1/3.0

openssl-machine pushed a commit that referenced this pull request Feb 21, 2024
@mattcaswell
Don't print excessively long ASN1 items in fuzzer
878d319 
Prevent spurious fuzzer timeouts by not printing ASN1 which is excessively
long.

This fixes a false positive encountered by OSS-Fuzz.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
(Merged from #23640)

(cherry picked from commit 4a6f70c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@shahsb shahsb shahsb approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mattcaswell @openssl-machine @t8m @shahsb @tom-cosgrove-arm