apps/pkcs12: Not writing the privateKey.pem file until the import password is verified

[naaysayer]

Fixes #904

CLA: trivial

Relocating the code responsible for opening the output file to the 'dump' label. All validation was performed before, and a file would not be written if any of the validation failed.

[shahsb]

Ok with Trivial

[t8m]

OK with CLA:trivial as this is just moving the code around.

[openssl-machine]

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

[openssl-machine]

This PR is in a state where it requires action by @openssl/committers but the last update was 61 days ago

[beldmit]

LGTM, agree with trivial

[beldmit]

close/open to rerun tests

[beldmit]

BTW, why do we have ABI change label on this PR?

[bernd-edlinger]

Hmm, the main reason why #904 did not make any progress so far, is probably
that there are many other commands that have the same behavior that the output file
is empty when the output password was not typed in correctly.
e.g.
apps/openssl genpkey -paramfile test/testec-p112r1.pem -aes-128-cbc -out xxx.pem
the out fille is also created before the password is entered, and will be empty if password
is too short, or something goes wrong.
Are there other commands where the output file is not created when the password is empty,
or will this be the first one?

[naaysayer]

Hmm, the main reason why #904 did not make any progress so far, is probably that there are many other commands that have the same behavior that the output file is empty when the output password was not typed in correctly. e.g. apps/openssl genpkey -paramfile test/testec-p112r1.pem -aes-128-cbc -out xxx.pem the out fille is also created before the password is entered, and will be empty if password is too short, or something goes wrong. Are there other commands where the output file is not created when the password is empty, or will this be the first one?

ok, I will look into other commands. Should I fix all of them in the same manner as the current one?

[bernd-edlinger]

It would be good to have consistent behavior between all the different commands.
Even if that means setting the output file to empty, at ideally there should be
a general rule that is used everywhere and not exceptions.

[openssl-machine]

This pull request is ready to merge

[t8m]

Merged to all the active branches. Thank you for your contribution.