QUIC: Enable qlog support by default #23744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlandau
added
branch: master
hlandau
force-pushed
the
quic-enable-qlog
branch
from
d5633bf
to
8a1c0e8
Compare
hlandau
force-pushed
the
quic-enable-qlog
branch
from
8a1c0e8
to
5d17171
Compare
t-j-h
approved these changes
Mar 4, 2024
t-j-h
added
the
approval: review pending
nhorman
approved these changes
Mar 5, 2024
t-j-h
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to master. Thanks for the reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
Mar 6, 2024
Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from #23744)
openssl-machine
pushed a commit
that referenced
this pull request
Mar 6, 2024
Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from #23744)
openssl-machine
pushed a commit
that referenced
this pull request
Mar 6, 2024
Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from #23744)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After engaging with the qlog effort in the IETF QUIC WG I have come to an evolved understanding of the 'philosophy' behind qlog. I now believe that the emphasis placed on future format changes in OpenSSL was excessive. See my comments here for details: quicwg/qlog#371 (comment)
I believe we have provided adequate warning of future changes in the available documentation.
There is no policy issue with doing this as this is not a cryptographic primitive or protocol.
For 3.3.