riscv: Fix remaining asm checks #23752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are additional asm checks which don't check for OPENSSL_CPUID_OBJ causing the build to still fail on riscv [1], so fix them in the same manner as ff27959 [1] https://bugs.gentoo.org/923956 Fixes: openssl#22871
openssl-machine
added
the
hold: cla required
|
This should be fixed. But I also think Gentoo shouldn't be offering a no-asm build. |
|
I've signed and sent the CLA via e-mail. |
openssl-machine
removed
the
hold: cla required
t8m
approved these changes
Mar 8, 2024
t8m
added
branch: master
github-actions
bot
added
the
severity: fips change
|
ping for second review |
slontis
approved these changes
Mar 17, 2024
slontis
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to the master, 3.3 and 3.2 branches. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Mar 22, 2024
There are additional asm checks which don't check for OPENSSL_CPUID_OBJ causing the build to still fail on riscv [1], so fix them in the same manner as ff27959 [1] https://bugs.gentoo.org/923956 Fixes: #22871 Reviewed-by: Shane Lontis <shane.lontis@oracle.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #23752) (cherry picked from commit daf1f8d)
openssl-machine
pushed a commit
that referenced
this pull request
Mar 22, 2024
There are additional asm checks which don't check for OPENSSL_CPUID_OBJ causing the build to still fail on riscv [1], so fix them in the same manner as ff27959 [1] https://bugs.gentoo.org/923956 Fixes: #22871 Reviewed-by: Shane Lontis <shane.lontis@oracle.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #23752)
openssl-machine
pushed a commit
that referenced
this pull request
Mar 22, 2024
There are additional asm checks which don't check for OPENSSL_CPUID_OBJ causing the build to still fail on riscv [1], so fix them in the same manner as ff27959 [1] https://bugs.gentoo.org/923956 Fixes: #22871 Reviewed-by: Shane Lontis <shane.lontis@oracle.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #23752) (cherry picked from commit daf1f8d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are additional asm checks which don't check for OPENSSL_CPUID_OBJ causing the build to still fail on riscv [1], so fix them in the same manner as ff27959
[1] https://bugs.gentoo.org/923956
Fixes: #22871