Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RFC 5869 test case for HKDF self-test #23833

Closed
wants to merge 1 commit into from

Conversation

0140454
Copy link
Contributor

@0140454 0140454 commented Mar 14, 2024

According to NIST SP 800-131Ar2 section 8, the length of the key-derivation key shall be at least 112 bits.

This PR update the test data for HKDF using RFC 5869 test case 1.

Checklist
  • documentation is added or updated
  • tests are added or updated

@slontis slontis added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member labels Mar 14, 2024
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Mar 14, 2024
@t8m t8m added triaged: feature The issue/pr requests/adds a feature tests: exempted The PR is exempt from requirements for testing labels Mar 14, 2024
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Mar 14, 2024
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Mar 14, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Mar 15, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

According to NIST SP 800-131Ar2 section 8, the length of the
key-derivation key shall be at least 112 bits.
@0140454
Copy link
Contributor Author

0140454 commented Mar 28, 2024

Rebased dev branch onto current master branch.

@t8m
Copy link
Member

t8m commented Apr 2, 2024

Merged to the master branch. Thank you for your contribution.

@t8m t8m closed this Apr 2, 2024
openssl-machine pushed a commit that referenced this pull request Apr 2, 2024
According to NIST SP 800-131Ar2 section 8, the length of the
key-derivation key shall be at least 112 bits.

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23833)
@0140454 0140454 deleted the update-hkdf-selftest branch April 11, 2024 06:50
xnox pushed a commit to xnox/openssl that referenced this pull request Apr 22, 2024
According to NIST SP 800-131Ar2 section 8, the length of the
key-derivation key shall be at least 112 bits.

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#23833)

(cherry picked from commit 23fd48d)
Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@surgut.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch severity: fips change The pull request changes FIPS provider sources tests: exempted The PR is exempt from requirements for testing triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants