New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use RFC 5869 test case for HKDF self-test #23833
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slontis
added
branch: master
Merge to master branch
approval: review pending
This pull request needs review by a committer
approval: otc review pending
This pull request needs review by an OTC member
labels
Mar 14, 2024
github-actions
bot
added
the
severity: fips change
The pull request changes FIPS provider sources
label
Mar 14, 2024
This was referenced Mar 14, 2024
t8m
added
triaged: feature
The issue/pr requests/adds a feature
tests: exempted
The PR is exempt from requirements for testing
labels
Mar 14, 2024
t8m
approved these changes
Mar 14, 2024
t8m
removed
the
approval: otc review pending
This pull request needs review by an OTC member
label
Mar 14, 2024
tom-cosgrove-arm
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tom-cosgrove-arm
added
approval: done
This pull request has the required number of approvals
and removed
approval: review pending
This pull request needs review by a committer
labels
Mar 14, 2024
openssl-machine
added
approval: ready to merge
The 24 hour grace period has passed, ready to merge
and removed
approval: done
This pull request has the required number of approvals
labels
Mar 15, 2024
This pull request is ready to merge |
2 tasks
According to NIST SP 800-131Ar2 section 8, the length of the key-derivation key shall be at least 112 bits.
0140454
force-pushed
the
update-hkdf-selftest
branch
from
March 28, 2024 15:08
b49dde6
to
d00011f
Compare
Rebased dev branch onto current master branch. |
Merged to the master branch. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Apr 2, 2024
According to NIST SP 800-131Ar2 section 8, the length of the key-derivation key shall be at least 112 bits. Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #23833)
xnox
pushed a commit
to xnox/openssl
that referenced
this pull request
Apr 22, 2024
According to NIST SP 800-131Ar2 section 8, the length of the key-derivation key shall be at least 112 bits. Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#23833) (cherry picked from commit 23fd48d) Signed-off-by: Dimitri John Ledkov <dimitri.ledkov@surgut.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approval: ready to merge
The 24 hour grace period has passed, ready to merge
branch: master
Merge to master branch
severity: fips change
The pull request changes FIPS provider sources
tests: exempted
The PR is exempt from requirements for testing
triaged: feature
The issue/pr requests/adds a feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to NIST SP 800-131Ar2 section 8, the length of the key-derivation key shall be at least 112 bits.
This PR update the test data for HKDF using RFC 5869 test case 1.
Checklist