Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plug potential memory leak in error code path #23836

Closed
wants to merge 1 commit into from
Closed

plug potential memory leak in error code path #23836

wants to merge 1 commit into from

Conversation

Sashan
Copy link
Contributor

@Sashan Sashan commented Mar 14, 2024

Function module_add() may leak stack of modules when it fails to initialize newly added module.

Fixes #23835

@Sashan
plug potential memory leak in error code path
a6bf1c9 
Function `module_add()` may leak stack of modules when
it fails to initialize newly added module.

Fixes openssl#23835
@Sashan Sashan requested review from mattcaswell and t8m March 14, 2024 08:59
@Sashan Sashan added the tests: present The PR has suitable tests present label Mar 14, 2024
@mattcaswell mattcaswell added branch: master Merge to master branch approval: review pending This pull request needs review by a committer tests: exempted The PR is exempt from requirements for testing and removed tests: present The PR has suitable tests present labels Mar 14, 2024
@t8m t8m added approval: done This pull request has the required number of approvals triaged: bug The issue/pr is/fixes a bug and removed approval: review pending This pull request needs review by a committer labels Mar 14, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Mar 15, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Mar 15, 2024

Merged to the master branch. Thank you.

@t8m t8m closed this Mar 15, 2024
openssl-machine pushed a commit that referenced this pull request Mar 15, 2024
@Sashan @t8m
plug potential memory leak in error code path
707b54b 
Function `module_add()` may leak stack of modules when
it fails to initialize newly added module.

Fixes #23835

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23836)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A memory leak defect was discovered on line 375 of the file conf_mod.c in /openssl/crypto/conf/.
4 participants
@Sashan @openssl-machine @t8m @mattcaswell