Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'documentation policy' link to CONTRIBUTING guide. #23875

Closed
wants to merge 1 commit into from
Closed

Add 'documentation policy' link to CONTRIBUTING guide. #23875

wants to merge 1 commit into from

Conversation

slontis
Copy link
Member

@slontis slontis commented Mar 18, 2024

Checklist
  • documentation is added or updated
  • tests are added or updated

@slontis slontis added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member labels Mar 18, 2024
beldmit
beldmit approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member labels Mar 18, 2024
@t8m t8m added triaged: documentation The issue/pr deals with documentation (errors) branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing branch: 3.2 Merge to openssl-3.2 labels Mar 18, 2024
t8m
t8m approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this should go in all branches. @nhorman @slontis @beldmit do you agree?

@nhorman
Copy link
Contributor

nhorman commented Mar 18, 2024

ACK, yes to all branches, once the tree thaws

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@slontis slontis added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Mar 24, 2024
@t8m t8m added the branch: 3.3 Merge to openssl-3.3 label Apr 4, 2024
@t8m
Copy link
Member

t8m commented Apr 4, 2024

Merged to all the active branches. Thank you for your contribution.

@t8m t8m closed this Apr 4, 2024
openssl-machine pushed a commit that referenced this pull request Apr 4, 2024
@slontis @t8m
Add 'documentation policy' link to CONTRIBUTING guide.
e817766 
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23875)
openssl-machine pushed a commit that referenced this pull request Apr 4, 2024
@slontis @t8m
Add 'documentation policy' link to CONTRIBUTING guide.
6a22027 
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23875)

(cherry picked from commit e817766)
openssl-machine pushed a commit that referenced this pull request Apr 4, 2024
@slontis @t8m
Add 'documentation policy' link to CONTRIBUTING guide.
1956f09 
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23875)

(cherry picked from commit e817766)
openssl-machine pushed a commit that referenced this pull request Apr 4, 2024
@slontis @t8m
Add 'documentation policy' link to CONTRIBUTING guide.
9d15279 
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23875)

(cherry picked from commit e817766)
openssl-machine pushed a commit that referenced this pull request Apr 4, 2024
@slontis @t8m
Add 'documentation policy' link to CONTRIBUTING guide.
5405606 
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23875)

(cherry picked from commit e817766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhorman nhorman nhorman approved these changes

@t8m t8m t8m approved these changes

@beldmit beldmit beldmit approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 tests: exempted The PR is exempt from requirements for testing triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@slontis @nhorman @openssl-machine @t8m @beldmit