Disable support for DSA sign and key gen by default in the FIPS provider. #23890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
severity: fips change
t8m
added
branch: master
slontis
force-pushed
the
fips_no_dsa_sig
branch
2 times, most recently
from
3039876
to
b51fa36
Compare
github-actions
bot
added
the
severity: ABI change
slontis
force-pushed
the
fips_no_dsa_sig
branch
from
c2de061
to
5520f11
Compare
2 tasks
slontis
changed the title
whenever a non approved algorithm test has occurred. It may be used to log non approved algorithms. The callback is passed a name and description string. The return value can be either 0 or 1. A value of 0 can be used to force an error to occur from the algorithm that called the callback.
DSA signing is no longer approved (in FIPS 140-3). By default DSA signing wil not be enabled, and will result in an error. Non approved DSA signing in the FIPS provider can be enabled by either 1) By using the fipsinstall option 'no_dsa_check' OR 2) By setting the OSSL_PARAM OSSL_ALG_PARAM_STRICT_CHECKS to zero during the signature init. When using non approved signing the user may register a callback using OSSL_INDICATOR_set_callback() that can be used to indicate non approved behaviour.
Since DSA generated keys can only be used for signing purposes, restrict the DSA Keygen also for FIPS 140-3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIPS 140-3 now uses FIPS 186-5 which removes DSA.
DSA may still be used for Verification for legacy purposes.
Checklist