Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace size_t with int and add the check for the EVP_MD_get_size() #23924

Closed
wants to merge 1 commit into from
Closed

Replace size_t with int and add the check for the EVP_MD_get_size() #23924

wants to merge 1 commit into from

Conversation

JiangJias
Copy link
Contributor

Replace the type of "digest_size" with int to avoid implicit conversion when it is assigned by EVP_MD_get_size(). Moreover, add the check for the "digest_size".

Fixes: 29ce106 ("Update the demos/README file because it is really old. New demos should provide best practice for API use. Add demonstration for computing a SHA3-512 digest - digest/EVP_MD_demo")

Checklist
  • documentation is added or updated
  • tests are added or updated

@JiangJias
Replace size_t with int and add the check for the EVP_MD_get_size()
f823d7d 
Replace the type of "digest_size" with int to avoid implicit conversion when it is assigned by EVP_MD_get_size().
Moreover, add the check for the "digest_size".

Fixes: 29ce106 ("Update the demos/README file because it is really old. New demos should provide best practice for API use. Add demonstration for computing a SHA3-512 digest - digest/EVP_MD_demo")
Signed-off-by: Jiasheng Jiang <jiasheng@purdue.edu>
@mattcaswell mattcaswell added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly tests: exempted The PR is exempt from requirements for testing branch: 3.3 Merge to openssl-3.3 labels Mar 22, 2024
@kroeckx kroeckx added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Mar 22, 2024
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Mar 23, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Mar 23, 2024
@t8m t8m added branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 triaged: documentation The issue/pr deals with documentation (errors) and removed triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly labels Mar 25, 2024
@t8m
Copy link
Member

t8m commented Mar 25, 2024

This is a documentation fix, should go to all branches.

openssl-machine pushed a commit that referenced this pull request Mar 25, 2024
@JiangJias @t8m
Replace size_t with int and add the check for the EVP_MD_get_size()
87e7470 
Replace the type of "digest_size" with int to avoid implicit conversion when it is assigned by EVP_MD_get_size().
Moreover, add the check for the "digest_size".

Fixes: 29ce106 ("Update the demos/README file because it is really old. New demos should provide best practice for API use. Add demonstration for computing a SHA3-512 digest - digest/EVP_MD_demo")
Signed-off-by: Jiasheng Jiang <jiasheng@purdue.edu>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23924)
@t8m t8m removed the branch: 3.0 Merge to openssl-3.0 branch label Mar 25, 2024
@t8m
Copy link
Member

t8m commented Mar 25, 2024

Merged to the master, 3.3, 3.2 and 3.1 branches. Does not apply to 3.0. Thank you for your contribution.

@t8m t8m closed this Mar 25, 2024
openssl-machine pushed a commit that referenced this pull request Mar 25, 2024
@JiangJias @t8m
Replace size_t with int and add the check for the EVP_MD_get_size()
ba3b337 
Replace the type of "digest_size" with int to avoid implicit conversion when it is assigned by EVP_MD_get_size().
Moreover, add the check for the "digest_size".

Fixes: 29ce106 ("Update the demos/README file because it is really old. New demos should provide best practice for API use. Add demonstration for computing a SHA3-512 digest - digest/EVP_MD_demo")
Signed-off-by: Jiasheng Jiang <jiasheng@purdue.edu>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23924)

(cherry picked from commit 87e7470)
openssl-machine pushed a commit that referenced this pull request Mar 25, 2024
@JiangJias @t8m
Replace size_t with int and add the check for the EVP_MD_get_size()
022249e 
Replace the type of "digest_size" with int to avoid implicit conversion when it is assigned by EVP_MD_get_size().
Moreover, add the check for the "digest_size".

Fixes: 29ce106 ("Update the demos/README file because it is really old. New demos should provide best practice for API use. Add demonstration for computing a SHA3-512 digest - digest/EVP_MD_demo")
Signed-off-by: Jiasheng Jiang <jiasheng@purdue.edu>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23924)

(cherry picked from commit 87e7470)
openssl-machine pushed a commit that referenced this pull request Mar 25, 2024
@JiangJias @t8m
Replace size_t with int and add the check for the EVP_MD_get_size()
0117a02 
Replace the type of "digest_size" with int to avoid implicit conversion when it is assigned by EVP_MD_get_size().
Moreover, add the check for the "digest_size".

Fixes: 29ce106 ("Update the demos/README file because it is really old. New demos should provide best practice for API use. Add demonstration for computing a SHA3-512 digest - digest/EVP_MD_demo")
Signed-off-by: Jiasheng Jiang <jiasheng@purdue.edu>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #23924)

(cherry picked from commit 87e7470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroeckx kroeckx kroeckx approved these changes

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 tests: exempted The PR is exempt from requirements for testing triaged: documentation The issue/pr deals with documentation (errors)
Projects
Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JiangJias @openssl-machine @t8m @kroeckx @mattcaswell