New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASYNC_start_job: more readable documentation for handling ASYNC* APIs #23941
Conversation
About the failing CI check:
we can't link to basic C man pages? |
According to this: We should be able to. I wonder if successful linking is incumbent on the target man pages being installed? I would imagine that the ci images that do the doc-nits check have them all stripped |
Oh, I found the problem, its twofold:
|
Sounds like I shouldn't link to them then... |
yeah, probably not, as the L<> tag assumes that the link target is included in the docs tree. We could potentially use this syntax:
There are several sites that provide canonical man pages in html form, but I'm not sure what the policy is on linking to external sources |
Signed-off-by: Hubert Kario <hkario@redhat.com>
no-shared-macos (macos-14) failure looks unrelated: seems to be a race condition in the test case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request is ready to merge |
merged, thank you for your contribution |
Signed-off-by: Hubert Kario <hkario@redhat.com> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> Reviewed-by: Neil Horman <nhorman@openssl.org> (Merged from #23941)
Recently I was trying to figure out how to use the OpenSSL APIs combined with the ASYNC multithreading and found the documentation hard to follow.
Added few more comments that would probably made it easier to the past me.
Checklist