ssl/t1_lib.c: Add checks for the EVP_MD_get_size() #23943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t8m
approved these changes
Mar 25, 2024
t8m
added
branch: master
nhorman
approved these changes
Mar 25, 2024
tom-cosgrove-arm
approved these changes
Mar 26, 2024
tom-cosgrove-arm
added
approval: done
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
|
merged, thank you for your contribution |
openssl-machine
pushed a commit
that referenced
this pull request
Apr 2, 2024
Add checks for the EVP_MD_get_size() to avoid unexpected negative numbers. Fixes: b362cca ("Security framework.") Fixes: 0fe3db2 ("Use size of server key when selecting signature algorithm.") Signed-off-by: Jiasheng Jiang <jiasheng@purdue.edu> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> (Merged from #23943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checks for the EVP_MD_get_size() to avoid unexpected negative numbers.
Fixes: b362cca ("Security framework.")
Fixes: 0fe3db2 ("Use size of server key when selecting signature algorithm.")
Checklist