Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGES.md and NEWS.md with changes that have occurred since 3.2 #23998

Closed
wants to merge 2 commits into from
Closed

Update CHANGES.md and NEWS.md with changes that have occurred since 3.2 #23998

wants to merge 2 commits into from

Conversation

mattcaswell
Copy link
Member

Release: yes

I've added the "Release: yes" header for this commit. As per the committer policy the author counts as a reviewer for CHANGES/NEWS updates for a release.

Added the urgent tag as this is needed for today's beta release.

For CHANGES.md I've gone through the commit log for all changes since 3.2 and added several items that I thought justified a CHANGES.md entry but hadn't previously been included.

I've used the new NEWS.md structure as we did for 3.2, but i reordered it so that new features comes first, followed by "significant or incompatible updates". I dropped the sections for known issues and documentation enhancements since I didn't have anything to report there.

@mattcaswell mattcaswell added approval: review pending This pull request needs review by a committer severity: urgent Fixes an urgent issue (exempt from 24h grace period) branch: 3.3 Merge to openssl-3.3 labels Mar 29, 2024
@hlandau
Copy link
Member

hlandau commented Mar 29, 2024

Approved but I recommend the following addition. I forgot to mention SSL_poll in CHANGES.md. Neil's RCU work also warrants acknowledgement.

 * Limited support for polling of QUIC connection and stream objects in a
   non-blocking manner. Refer to the SSL_poll(3) manpage for details.

   *Hugo Landau*

 * A new RCU lock infrastructure has been added to enable more performant
   locking for read-mostly structures in highly threaded scenarios.

   *Neil Horman*

kroeckx
kroeckx reviewed Mar 29, 2024
View reviewed changes
NEWS.md
* Various optimizations for cryptographic routines using RISC-V vector crypto
extensions

* Added assembly implementation for md5 on loongarch64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why any of those are mentioned in this section.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw them as "potentially significant" changes, i.e. they're not new features, but things things that people might be interested in anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should split this up in more sections? But I'm fine with having that fixed after the release.

@mattcaswell
Copy link
Member Author

Neil's RCU work also warrants acknowledgement.

I agree this does warrant acknowledgement - but I'm wondering whether doing it in this release is premature since we're not actually really using it yet - its just purely internal changes that no one will notice. Would it be better to defer pulling this into CHANGES/NEWS until such time that we are making substantial use of it?

@mattcaswell
Copy link
Member Author

Fixup pushed adding the SSL_poll feature to both CHANGES/NEWS. I've not added RCU at this time.

@mattcaswell mattcaswell added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: review pending This pull request needs review by a committer labels Mar 29, 2024
@mattcaswell
Copy link
Member Author

@hlandau do you agree this is urgent?

@mattcaswell mattcaswell added approval: review pending This pull request needs review by a committer and removed approval: ready to merge The 24 hour grace period has passed, ready to merge labels Mar 29, 2024
@nhorman
Copy link
Contributor

nhorman commented Mar 29, 2024

agree urgent

@hlandau
Copy link
Member

hlandau commented Mar 29, 2024 •
edited

I have no objection to this going in immediately as I see it as part of the release process... IMO a different kind of authorization than our urgent process.

@mattcaswell mattcaswell added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: review pending This pull request needs review by a committer labels Mar 29, 2024
@mattcaswell
Copy link
Member Author

Pushed to the 3.3 branch. Thanks for all your input.

openssl-machine pushed a commit that referenced this pull request Mar 29, 2024
@mattcaswell
Update CHANGES.md and NEWS.md with changes that have occurred since 3.2
5a088e1 
Release: yes

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
(Merged from #23998)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroeckx kroeckx kroeckx left review comments

@nhorman nhorman nhorman approved these changes

@hlandau hlandau hlandau approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: 3.3 Merge to openssl-3.3 severity: urgent Fixes an urgent issue (exempt from 24h grace period)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mattcaswell @hlandau @nhorman @kroeckx