Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add locking to atomic operations in rw/rcu tests #24001

Closed
wants to merge 2 commits into from
Closed

Add locking to atomic operations in rw/rcu tests #24001

wants to merge 2 commits into from

Commits on Mar 29, 2024

  1. Add locking to atomic operations in rw/rcu tests 

    I neglected to add locks to the calls to CRYPTO_atomic_add in these
test, which on newer compilers is fine, as atomic operations are
defined.  However on older compilers the __ATOMIC_ACQ_REL definition is
missing causing these function to be implemented using an rwlock, which
when NULL causes the locks to fail.

Fix this my creating the lock and using them appropriately
    @nhorman
    nhorman committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    591784a View commit details
    Browse the repository at this point in the history

  2. amend! Add locking to atomic operations in rw/rcu tests 

    Add locking to atomic operations in rw/rcu tests

I neglected to add locks to the calls to CRYPTO_atomic_add in these
test, which on newer compilers is fine, as atomic operations are
defined.  However on older compilers the __ATOMIC_ACQ_REL definition is
missing causing these function to be implemented using an rwlock, which
when NULL causes the locks to fail.

Fix this my creating the lock and using them appropriately

Fixes openssl#24000
    @nhorman
    nhorman committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    977982b View commit details
    Browse the repository at this point in the history