Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diverse small VMS build fixups #24008

Closed
wants to merge 1 commit into from
Closed

Diverse small VMS build fixups #24008

wants to merge 1 commit into from

Conversation

levitte
Copy link
Member

@levitte levitte commented Mar 30, 2024 •
edited

Without these, builds break for openssl-3.3, and master

@levitte levitte added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug branch: 3.3 Merge to openssl-3.3 labels Mar 30, 2024
@t8m t8m added the tests: exempted The PR is exempt from requirements for testing label Apr 3, 2024
@t8m t8m added severity: regression The issue/pr is a regression from previous released version and removed approval: otc review pending This pull request needs review by an OTC member labels Apr 3, 2024
@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 3, 2024
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Apr 4, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Apr 4, 2024
@t8m
Copy link
Member

t8m commented Apr 4, 2024

Merged to the master and 3.3 branches. Thank you.

@t8m t8m closed this Apr 4, 2024
openssl-machine pushed a commit that referenced this pull request Apr 4, 2024
@levitte @t8m
Diverse small VMS build fixups
a19553c 
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24008)

(cherry picked from commit 1a4b029)
openssl-machine pushed a commit that referenced this pull request Apr 4, 2024
@levitte @t8m
Diverse small VMS build fixups
1a4b029 
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24008)
@levitte levitte deleted the VMS-fixes-202404 branch April 9, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhorman nhorman nhorman approved these changes

@t8m t8m t8m approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

@hlandau hlandau Awaiting requested review from hlandau

@mattcaswell mattcaswell Awaiting requested review from mattcaswell

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.3 Merge to openssl-3.3 severity: regression The issue/pr is a regression from previous released version tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@levitte @openssl-machine @t8m @nhorman @tom-cosgrove-arm