Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit key checks in the decoder fuzzer #24049

Closed
wants to merge 2 commits into from
Closed

Conversation

t8m
Copy link
Member

@t8m t8m commented Apr 5, 2024

In particular the DH safe prime check will be limited to 8192 bits and the private and pairwise checks are limited to 16384 bits on any key types.

Checklist
  • documentation is added or updated

t8m added 2 commits April 5, 2024 16:29
In particular the DH safe prime check will be limited to 8192 bits
and the private and pairwise checks are limited to 16384 bits on
any key types.
@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug triaged: documentation The issue/pr deals with documentation (errors) branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 labels Apr 5, 2024
@t8m t8m requested a review from kroeckx April 5, 2024 14:33
@nhorman nhorman removed their assignment Apr 5, 2024
@slontis slontis removed the approval: otc review pending This pull request needs review by an OTC member label Apr 8, 2024
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 8, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 9, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Apr 10, 2024
In particular the DH safe prime check will be limited to 8192 bits
and the private and pairwise checks are limited to 16384 bits on
any key types.

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #24049)

(cherry picked from commit 9fc61ba)
openssl-machine pushed a commit that referenced this pull request Apr 10, 2024
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #24049)

(cherry picked from commit 27005ce)
openssl-machine pushed a commit that referenced this pull request Apr 10, 2024
In particular the DH safe prime check will be limited to 8192 bits
and the private and pairwise checks are limited to 16384 bits on
any key types.

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #24049)
openssl-machine pushed a commit that referenced this pull request Apr 10, 2024
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #24049)
openssl-machine pushed a commit that referenced this pull request Apr 10, 2024
In particular the DH safe prime check will be limited to 8192 bits
and the private and pairwise checks are limited to 16384 bits on
any key types.

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #24049)

(cherry picked from commit 9fc61ba)
openssl-machine pushed a commit that referenced this pull request Apr 10, 2024
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #24049)

(cherry picked from commit 27005ce)
openssl-machine pushed a commit that referenced this pull request Apr 10, 2024
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #24049)

(cherry picked from commit 27005ce)
@t8m
Copy link
Member Author

t8m commented Apr 10, 2024

Merged to all the active branches. (in 3.1 and 3.0 only the documentation improvement as the fuzz test is not there) Thank you for the reviews.

@t8m t8m closed this Apr 10, 2024
openssl-machine pushed a commit that referenced this pull request Apr 10, 2024
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #24049)

(cherry picked from commit 27005ce)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug triaged: documentation The issue/pr deals with documentation (errors)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants