Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation Edit provider-compatibility.yml CLA: Trivial #24164

Closed
wants to merge 1 commit into from
Closed

Documentation Edit provider-compatibility.yml CLA: Trivial #24164

wants to merge 1 commit into from

Conversation

rlvkleinhenz
Copy link
Contributor

Documentation Change: Line 34

Changed 'utl' to 'url' to correctly reflect the variables used in the releases in this file.

CLA: trivial

@bbbrumley

Checklist
  • documentation is added or updated
  • tests are added or updated

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Apr 16, 2024
@rlvkleinhenz rlvkleinhenz changed the title Documentation Edit provider-compatibility.yml Documentation Edit provider-compatibility.yml CLA: Trivial Apr 16, 2024
@t8m
Copy link
Member

t8m commented Apr 16, 2024

The CLA: trivial annotation needs to be in the git commit message body not just in the PR description. Could you please amend that commit message (git commit --amend; git push --force would do that).

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member cla: trivial One of the commits is marked as 'CLA: trivial' triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly tests: exempted The PR is exempt from requirements for testing labels Apr 16, 2024
@rlvkleinhenz
Update provider-compatibility.yml
0fc92f5 
Documentation Change: Line 34

Changed 'utl' to 'url' to correctly reflect the variables used in the releases in this file.

CLA: trivial
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Apr 16, 2024
paulidale
paulidale approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay with trivial

@paulidale paulidale removed the approval: otc review pending This pull request needs review by an OTC member label Apr 16, 2024
@levitte levitte added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 17, 2024
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Apr 17, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 18, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Apr 18, 2024

Merged to the master branch. Thank you for your contribution.

@t8m t8m closed this Apr 18, 2024
openssl-machine pushed a commit that referenced this pull request Apr 18, 2024
@rlvkleinhenz @t8m
Update provider-compatibility.yml
4174f26 
Documentation Change: Line 34

Changed 'utl' to 'url' to correctly reflect the variables used in the releases in this file.

CLA: trivial

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #24164)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial' severity: fips change The pull request changes FIPS provider sources tests: exempted The PR is exempt from requirements for testing triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rlvkleinhenz @t8m @openssl-machine @levitte @paulidale