Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMP: fix reporting error when no root CA cert update available #24169

Closed
wants to merge 4 commits into from
Closed

CMP: fix reporting error when no root CA cert update available #24169

wants to merge 4 commits into from

Conversation

rajeev-0
Copy link
Contributor

@rajeev-0 rajeev-0 commented Apr 17, 2024 •
edited

This pull request addresses the issue where an error occurs when the root CA certificate update is not available. In this case, the client should not classify it as an error.

Checklist
  • documentation is added or updated
  • tests are added or updated

DDvO
DDvO reviewed Apr 17, 2024
View reviewed changes
crypto/cmp/cmp_asn.c Outdated Show resolved Hide resolved
DDvO
DDvO requested changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@DDvO DDvO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two more nits.

crypto/cmp/cmp_asn.c Outdated Show resolved Hide resolved
test/recipes/80-test_cmp_http_data/test_commands.csv Outdated Show resolved Hide resolved
@rajeev-0 rajeev-0 requested a review from DDvO April 17, 2024 13:10
@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 tests: present The PR has suitable tests present labels Apr 18, 2024
DDvO
DDvO requested changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@DDvO DDvO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more little doc issues.

doc/man3/OSSL_CMP_ITAV_new_caCerts.pod Outdated Show resolved Hide resolved
DDvO
DDvO approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@DDvO DDvO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@DDvO DDvO removed the approval: review pending This pull request needs review by a committer label Apr 19, 2024
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: otc review pending This pull request needs review by an OTC member labels Apr 19, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 20, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Apr 22, 2024
@rajeev-0 @DDvO
fix sending error when no root CA cert update available
fc9649f 
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24169)
openssl-machine pushed a commit that referenced this pull request Apr 22, 2024
@rajeev-0 @DDvO
fix sending error when no root CA cert update available
8ffc172 
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24169)

(cherry picked from commit fc9649f)
openssl-machine pushed a commit that referenced this pull request Apr 22, 2024
@rajeev-0 @DDvO
fix sending error when no root CA cert update available
1fbbe1b 
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24169)

(cherry picked from commit fc9649f)
@DDvO
Copy link
Contributor

DDvO commented Apr 22, 2024

Merged to master, 3.3, and 3.2 -
thanks @rajeev-0 for the contribution and @t8m for the review.

@DDvO DDvO closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DDvO DDvO DDvO approved these changes

@t8m t8m t8m approved these changes

@shahsb shahsb shahsb approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 tests: present The PR has suitable tests present triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rajeev-0 @openssl-machine @DDvO @t8m @shahsb