Updated year on hkdf.c #24239
Closed
Updated year on hkdf.c #24239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the year on the license disclaimer. CLA: trivial
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2021-2023 The OpenSSL Project Authors. All Rights Reserved. | |||
| * Copyright 2021-2024 The OpenSSL Project Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
Hmm, it doesn't look to me that this file was updated in 2024 - the last change I see in here is
commit 86db958835d1f8ba9ce49a9f93b5309c3d13b91c
Author: James Muir <james@openssl.org>
Date: Fri Nov 10 14:02:00 2023 -0500
demos: tidy up makefiles, fix warnings
|
Generally speaking updating the copyright year in files like this is not normally necessary. We have a script that does this when we create a release from a branch (i.e. if a year is wrong it will be corrected when the contents of the master branch become the 3.4 release at some point in the future). https://github.com/openssl/tools/blob/master/release-tools/do-copyright-year |
|
Thanks both for the feedback @cm3173 In light of the comments, probably best to close this one out Nevertheless, thank you for submitting your PR |
t8m
added
triaged: cleanup
|
I will be closing it now. Thank you for working on this great project :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the year on the license disclaimer. @bbbrumley
CLA: trivial
Checklist