Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #24476 #24488

Closed
wants to merge 2 commits into from
Closed

Fixes #24476 #24488

wants to merge 2 commits into from

Conversation

NekSaikou
Copy link
Contributor

@NekSaikou NekSaikou commented May 24, 2024 •
edited
Loading

Checklist
  • tests are added or updated

CLA: trivial

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label May 24, 2024
@NekSaikou
Fixes openssl#24476
63189bf 
NekSaikou@proton.me
Fri May 24 10:45:01 2024 +0000
CLA: trivial
t8m
t8m requested changes May 24, 2024
View reviewed changes
test/ecstresstest.c Outdated Show resolved Hide resolved
@t8m t8m added branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 labels May 24, 2024
@NekSaikou
use goto instead
f70ec41 
CLA: trivial
@t8m t8m added cla: trivial One of the commits is marked as 'CLA: trivial' and removed hold: cla required The contributor needs to submit a license agreement labels May 27, 2024
t8m
t8m approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with CLA: trivial

@t8m t8m added the approval: review pending This pull request needs review by a committer label May 27, 2024
@nhorman nhorman added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 27, 2024
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically,alternatively please review and set the label manually.

@t8m t8m added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels May 28, 2024
@t8m
Copy link
Member

t8m commented May 28, 2024

Squashed, reworded the commit message and merged to all the active branches. Thank you for your contribution.

@t8m t8m closed this May 28, 2024
openssl-machine pushed a commit that referenced this pull request May 28, 2024
@NekSaikou @t8m
ecstresstest.c: Fix memory leak on error
bfde2d0 
Fixes #24476
CLA: trivial

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24488)

(cherry picked from commit 434e7f7)
openssl-machine pushed a commit that referenced this pull request May 28, 2024
@NekSaikou @t8m
ecstresstest.c: Fix memory leak on error
434e7f7 
Fixes #24476
CLA: trivial

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24488)
openssl-machine pushed a commit that referenced this pull request May 28, 2024
@NekSaikou @t8m
ecstresstest.c: Fix memory leak on error
3b19c89 
Fixes #24476
CLA: trivial

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24488)

(cherry picked from commit 434e7f7)
openssl-machine pushed a commit that referenced this pull request May 28, 2024
@NekSaikou @t8m
ecstresstest.c: Fix memory leak on error
1405f5d 
Fixes #24476
CLA: trivial

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24488)

(cherry picked from commit 434e7f7)
openssl-machine pushed a commit that referenced this pull request May 28, 2024
@NekSaikou @t8m
ecstresstest.c: Fix memory leak on error
d747043 
Fixes #24476
CLA: trivial

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24488)

(cherry picked from commit 434e7f7)
jvdsn pushed a commit to jvdsn/openssl that referenced this pull request Jun 3, 2024
@NekSaikou @jvdsn
ecstresstest.c: Fix memory leak on error
f927aea 
Fixes openssl#24476
CLA: trivial

Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#24488)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhorman nhorman nhorman approved these changes

@t8m t8m t8m approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 cla: trivial One of the commits is marked as 'CLA: trivial' tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NekSaikou @openssl-machine @t8m @nhorman