Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CHANGES.md entry for the EC/DSA nonce generation fixes #24660

Closed
wants to merge 2 commits into from
Closed

Add CHANGES.md entry for the EC/DSA nonce generation fixes #24660

wants to merge 2 commits into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Jun 17, 2024

We did not mention this change in recent releases anywhere but IMO it is worth adding to CHANGES.md.

This should be applied to all the active branches.

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: documentation The issue/pr deals with documentation (errors) branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 labels Jun 17, 2024
@mattcaswell mattcaswell removed the approval: otc review pending This pull request needs review by an OTC member label Jun 17, 2024
@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jun 18, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jun 19, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@beldmit
Copy link
Member

beldmit commented Jun 19, 2024

Shouldn't Red Hat persons be mentioned directly here?

@t8m
Copy link
Member Author

t8m commented Jun 19, 2024

Shouldn't Red Hat persons be mentioned directly here?

They can, if you tell me the names.

@beldmit
Copy link
Member

beldmit commented Jun 19, 2024

George Pantelakis and Hubert Kario

@t8m
Copy link
Member Author

t8m commented Jun 19, 2024

Fixup pushed @tom-cosgrove-arm @mattcaswell please reconfirm.

beldmit
beldmit approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tom-cosgrove-arm
tom-cosgrove-arm approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reconfirming, thanks

@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: ready to merge The 24 hour grace period has passed, ready to merge labels Jun 19, 2024
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Jun 20, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Jun 20, 2024
openssl-machine pushed a commit that referenced this pull request Jun 20, 2024
@t8m
Add CHANGES.md entry for the EC/DSA nonce generation fixes
72bff68 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #24660)
openssl-machine pushed a commit that referenced this pull request Jun 20, 2024
@t8m
Add CHANGES.md entry for the EC/DSA nonce generation fixes
c0088b9 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #24660)

(cherry picked from commit 72bff68)
@t8m
Copy link
Member Author

t8m commented Jun 20, 2024

Merged to all the active branches. Thank you for the reviews.

@t8m t8m closed this Jun 20, 2024
openssl-machine pushed a commit that referenced this pull request Jun 20, 2024
@t8m
Add CHANGES.md entry for the EC/DSA nonce generation fixes
ba389a5 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #24660)

(cherry picked from commit 72bff68)
openssl-machine pushed a commit that referenced this pull request Jun 20, 2024
@t8m
Add CHANGES.md entry for the EC/DSA nonce generation fixes
b00374b 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #24660)

(cherry picked from commit 72bff68)
openssl-machine pushed a commit that referenced this pull request Jun 20, 2024
@t8m
Add CHANGES.md entry for the EC/DSA nonce generation fixes
347cb1d 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #24660)

(cherry picked from commit 72bff68)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

@beldmit beldmit beldmit approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 tests: exempted The PR is exempt from requirements for testing triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@t8m @openssl-machine @beldmit @mattcaswell @tom-cosgrove-arm